|
[AMD Official Use Only - AMD Internal Distribution Only]
Looks good to me as well, With Christian's comment accommodated:
Acked-by: Shashank Sharma <shashank.sharma@xxxxxxx>
Regards
Shashank
From: Koenig, Christian <Christian.Koenig@xxxxxxx>
Sent: Friday, December 13, 2024 8:34 AM To: André Almeida <andrealmeid@xxxxxxxxxx>; Raag Jadav <raag.jadav@xxxxxxxxx>; airlied@xxxxxxxxx <airlied@xxxxxxxxx>; simona@xxxxxxxx <simona@xxxxxxxx>; lucas.demarchi@xxxxxxxxx <lucas.demarchi@xxxxxxxxx>; rodrigo.vivi@xxxxxxxxx <rodrigo.vivi@xxxxxxxxx>; jani.nikula@xxxxxxxxxxxxxxx <jani.nikula@xxxxxxxxxxxxxxx>; andriy.shevchenko@xxxxxxxxxxxxxxx <andriy.shevchenko@xxxxxxxxxxxxxxx>; lina@xxxxxxxxxxxxx <lina@xxxxxxxxxxxxx>; michal.wajdeczko@xxxxxxxxx <michal.wajdeczko@xxxxxxxxx>; Sharma, Shashank <Shashank.Sharma@xxxxxxx> Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; himal.prasad.ghimiray@xxxxxxxxx <himal.prasad.ghimiray@xxxxxxxxx>; aravind.iddamsetty@xxxxxxxxxxxxxxx <aravind.iddamsetty@xxxxxxxxxxxxxxx>; anshuman.gupta@xxxxxxxxx <anshuman.gupta@xxxxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>; kernel-dev@xxxxxxxxxx <kernel-dev@xxxxxxxxxx> Subject: Re: [PATCH 1/1] drm/amdgpu: Use device wedged event Am 12.12.24 um 20:09 schrieb André Almeida:
> Use DRM's device wedged event to notify userspace that a reset had > happened. For now, only use `none` method meant for telemetry > capture. > > Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 96316111300a..19e1a5493778 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -6057,6 +6057,9 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev, > dev_info(adev->dev, "GPU reset end with ret = %d\n", r); > > atomic_set(&adev->reset_domain->reset_res, r); > + > + drm_dev_wedged_event(adev_to_drm(adev), DRM_WEDGE_RECOVERY_NONE); That looks really good in general. I would just make the DRM_WEDGE_RECOVERY_NONE depend on the value of "r". @Shashank any objections? IIRC you have worked on the AMD specific event we never upstreamed. Regards, Christian. > + > return r; > } > |
