Re: [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

On Wed, Dec 11, 2024 at 02:52:20PM +0000, Krzysztof Karas wrote:
> Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(),
> use error pointers with informative codes. This will also trigger IS_ERR() in
> current caller (intel_dp_tunnerl_mgr_init()) instead of bypassing it via NULL
> pointer.
> 
> v2: use error codes inside drm_dp_tunnel_mgr_create() instead of handling
>  on caller's side (Michal, Imre)
> 
> Signed-off-by: Krzysztof Karas <krzysztof.karas@xxxxxxxxx>

Please:

 1. run checkpatch.pl before sending patches.
 2. don't ignore previous reviews: I asked you to add the fixes
    tag and two Cc
 3. run checkpatch.pl before sending patches.
 4. Because this is a fix you should Cc also the stable mailing
    list (for real!).
 5. Find the proper maintainers to Cc, this patch is outside
    Intel's territory; consider using, but not strictly,
    get_maintainer.pl

And, in case you forget:

 6. run checkpatch.pl before sending patches.

Looking forward for a v3.

Andi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux