On Wed, Dec 11, 2024 at 04:18:06PM +0100, Andi Shyti wrote: > Hi Krzysztof, > > On Wed, Dec 11, 2024 at 02:52:20PM +0000, Krzysztof Karas wrote: > > Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(), > > use error pointers with informative codes. This will also trigger IS_ERR() in > > current caller (intel_dp_tunnerl_mgr_init()) instead of bypassing it via NULL > > pointer. > > I was about to suggest fixing either this or his counterpart in > the header file. > > Please send this in a series along with the previous patch in > order to let people understand why you are sending this. Sorry, this patch works without the other, I got confused. It's fine, then: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> Thanks, Andi