On Wed, Dec 11, 2024 at 09:56:50AM +0000, Krzysztof Karas wrote: > drm_dp_tunnel_mgr_create() may return NULL on failure, which will not > be caught via IS_ERR(), so replace it with IS_ERR_OR_NULL() macro. > > Signed-off-by: Krzysztof Karas <krzysztof.karas@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_dp_tunnel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > index 94198bc04939..6c960416f776 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c > @@ -793,7 +793,7 @@ int intel_dp_tunnel_mgr_init(struct intel_display *display) > drm_connector_list_iter_end(&connector_list_iter); > > tunnel_mgr = drm_dp_tunnel_mgr_create(display->drm, dp_connectors); > - if (IS_ERR(tunnel_mgr)) > + if (IS_ERR_OR_NULL(tunnel_mgr)) > return PTR_ERR(tunnel_mgr); Thanks for spotting this. As Michal pointed out, instead of the above drm_dp_tunnel_mgr_create() should be fixed to return PTR_ERR(-ENOMEM) in case of an error. > > display->dp_tunnel_mgr = tunnel_mgr; > -- > 2.34.1 >
