Hi Nitin,
On Thu, Dec 05, 2024 at 05:27:36PM +0530, Nitin Gote wrote:
> Issue is seen again where engine resets fails because the engine resumes
> from an incorrect RING_HEAD. So, increase a time if at first the
> write doesn't succeed and retry again.
>
> Fixes: 6ef0e3ef2662 ("drm/i915/gt: Retry RING_HEAD reset until it get sticks")
Is this a real fix or is it more of a fine tuning?
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12806
> Signed-off-by: Nitin Gote <nitin.r.gote@xxxxxxxxx>
...
> @@ -231,7 +231,7 @@ static int xcs_resume(struct intel_engine_cs *engine)
> set_pp_dir(engine);
>
> /* First wake the ring up to an empty/idle ring */
> - for ((kt) = ktime_get() + (2 * NSEC_PER_MSEC);
> + for ((kt) = ktime_get() + (50 * NSEC_PER_MSEC);
Where is this 50 coming from?
Thanks,
Andi
> ktime_before(ktime_get(), (kt)); cpu_relax()) {
> /*
> * In case of resets fails because engine resumes from
> --
> 2.25.1
