Re: [PATCH v5 4/6] drm/i915/dp: Compute as_sdp.vtotal based on vrr timings

["Nautiyal, Ankit K" <ankit.k.nautiyal@xxxxxxxxx>]

On 12/2/2024 8:15 AM, Mitul Golani wrote:
> Compute as_sdp.vtotal based on minimum vtotal calculated
> during vrr computation.
>
> --v2:
>   - make a separate patch and update to vmin only [Ankit].
>
> --v3:
>   - Update vtotal to vmin for cmrr case as well [Ankit].
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx>


Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>

> ---
>   drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 306c00cab57e..98573dd69028 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2815,15 +2815,14 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
>   	as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC;
>   	as_sdp->length = 0x9;
>   	as_sdp->duration_incr_ms = 0;
> +	as_sdp->vtotal = crtc_state->vrr.vmin;
>   
>   	if (crtc_state->cmrr.enable) {
>   		as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED;
> -		as_sdp->vtotal = adjusted_mode->vtotal;
>   		as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode);
>   		as_sdp->target_rr_divider = true;
>   	} else {
>   		as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
> -		as_sdp->vtotal = adjusted_mode->vtotal;
>   		as_sdp->target_rr = 0;
>   	}
>   }