> -----Original Message----- > From: Golani, Mitulkumar Ajitkumar > <mitulkumar.ajitkumar.golani@xxxxxxxxx> > Sent: Monday, December 2, 2024 3:04 PM > To: Kandpal, Suraj <suraj.kandpal@xxxxxxxxx>; intel-xe@xxxxxxxxxxxxxxxxxxxxx; > intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Govindapillai, Vinod <vinod.govindapillai@xxxxxxxxx>; Nikula, Jani > <jani.nikula@xxxxxxxxx> > Subject: RE: [PATCH 3/6] drm/i915/wm: Rename enable_dpkgc variable > > > > > -----Original Message----- > > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of > > Suraj Kandpal > > Sent: 15 November 2024 21:31 > > To: intel-xe@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Govindapillai, Vinod <vinod.govindapillai@xxxxxxxxx>; Nikula, Jani > > <jani.nikula@xxxxxxxxx>; Kandpal, Suraj <suraj.kandpal@xxxxxxxxx> > > Subject: [PATCH 3/6] drm/i915/wm: Rename enable_dpkgc variable > > > > Rename the enable_dpkgc variable to make it more clear what it > > represents which is that if we are in fixed refresh rate or not. > > Changing names for the sake to this function doesn't make any sense to me > here, can be dropped if not required. It isn't just for the sake of function, Enable_dpkgc gets set only when we are at a fixed refresh rate which make the Name fixed_refresh_rate compared to enable_dpkgc since there are chances that DPKGC is Not enabled even though fixed refresh rate is enabled for less than LNL Regards, Suraj Kandpal > > > > Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/display/skl_watermark.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c > > b/drivers/gpu/drm/i915/display/skl_watermark.c > > index 6d5f64ed52ed..9ce3b5580df4 100644 > > --- a/drivers/gpu/drm/i915/display/skl_watermark.c > > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c > > @@ -2855,7 +2855,8 @@ static int skl_wm_add_affected_planes(struct > > intel_atomic_state *state, > > * Program PKG_C_LATENCY Added Wake Time = 0 > > */ > > static void > > -skl_program_dpkgc_latency(struct drm_i915_private *i915, bool > > enable_dpkgc) > > +skl_program_dpkgc_latency(struct drm_i915_private *i915, > > + bool fixed_refresh_rate) > > { > > u32 max_latency = LNL_PKG_C_LATENCY_MASK, added_wake_time = > 0; > > u32 clear, val; > > @@ -2863,7 +2864,7 @@ skl_program_dpkgc_latency(struct > > drm_i915_private *i915, bool enable_dpkgc) > > if (DISPLAY_VER(i915) < 20) > > return; > > > > - if (enable_dpkgc) { > > + if (fixed_refresh_rate) { > > max_latency = skl_watermark_max_latency(i915, 1); > > if (max_latency == 0) > > max_latency = LNL_PKG_C_LATENCY_MASK; > > -- > > 2.34.1