Hi Arun, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-plane-Expose-function-to-create-format-modifier-blob/20241121-105652 base: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes patch link: https://lore.kernel.org/r/20241118075315.466009-4-arun.r.murthy%40intel.com patch subject: [PATCHv2 3/3] drm/i915/display: Populate list of async supported formats/modifiers config: x86_64-randconfig-103-20241121 (https://download.01.org/0day-ci/archive/20241129/202411290757.FcxceZlQ-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411290757.FcxceZlQ-lkp@xxxxxxxxx/ cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/i915/display/skl_universal_plane.c:2626:26-32: ERROR: application of sizeof to pointer vim +2626 drivers/gpu/drm/i915/display/skl_universal_plane.c 2510 2511 struct intel_plane * 2512 skl_universal_plane_create(struct drm_i915_private *dev_priv, 2513 enum pipe pipe, enum plane_id plane_id) 2514 { 2515 const struct drm_plane_funcs *plane_funcs; 2516 struct intel_plane *plane; 2517 enum drm_plane_type plane_type; 2518 unsigned int supported_rotations; 2519 unsigned int supported_csc; 2520 const u64 *modifiers; 2521 u64 *async_modifiers; 2522 const u32 *formats; 2523 int num_formats; 2524 int ret; 2525 2526 plane = intel_plane_alloc(); 2527 if (IS_ERR(plane)) 2528 return plane; 2529 2530 plane->pipe = pipe; 2531 plane->id = plane_id; 2532 plane->frontbuffer_bit = INTEL_FRONTBUFFER(pipe, plane_id); 2533 2534 intel_fbc_add_plane(skl_plane_fbc(dev_priv, pipe, plane_id), plane); 2535 2536 if (DISPLAY_VER(dev_priv) >= 11) { 2537 plane->min_width = icl_plane_min_width; 2538 if (icl_is_hdr_plane(dev_priv, plane_id)) 2539 plane->max_width = icl_hdr_plane_max_width; 2540 else 2541 plane->max_width = icl_sdr_plane_max_width; 2542 plane->max_height = icl_plane_max_height; 2543 plane->min_cdclk = icl_plane_min_cdclk; 2544 } else if (DISPLAY_VER(dev_priv) >= 10) { 2545 plane->max_width = glk_plane_max_width; 2546 plane->max_height = skl_plane_max_height; 2547 plane->min_cdclk = glk_plane_min_cdclk; 2548 } else { 2549 plane->max_width = skl_plane_max_width; 2550 plane->max_height = skl_plane_max_height; 2551 plane->min_cdclk = skl_plane_min_cdclk; 2552 } 2553 2554 if (DISPLAY_VER(dev_priv) >= 13) 2555 plane->max_stride = adl_plane_max_stride; 2556 else 2557 plane->max_stride = skl_plane_max_stride; 2558 2559 if (DISPLAY_VER(dev_priv) >= 12) 2560 plane->min_alignment = tgl_plane_min_alignment; 2561 else 2562 plane->min_alignment = skl_plane_min_alignment; 2563 2564 if (DISPLAY_VER(dev_priv) >= 11) { 2565 plane->update_noarm = icl_plane_update_noarm; 2566 plane->update_arm = icl_plane_update_arm; 2567 plane->disable_arm = icl_plane_disable_arm; 2568 } else { 2569 plane->update_noarm = skl_plane_update_noarm; 2570 plane->update_arm = skl_plane_update_arm; 2571 plane->disable_arm = skl_plane_disable_arm; 2572 } 2573 plane->get_hw_state = skl_plane_get_hw_state; 2574 plane->check_plane = skl_plane_check; 2575 2576 if (plane_id == PLANE_1) { 2577 plane->need_async_flip_toggle_wa = IS_DISPLAY_VER(dev_priv, 9, 10); 2578 plane->async_flip = skl_plane_async_flip; 2579 plane->enable_flip_done = skl_plane_enable_flip_done; 2580 plane->disable_flip_done = skl_plane_disable_flip_done; 2581 } 2582 2583 if (DISPLAY_VER(dev_priv) >= 11) 2584 formats = icl_get_plane_formats(dev_priv, pipe, 2585 plane_id, &num_formats); 2586 else if (DISPLAY_VER(dev_priv) >= 10) 2587 formats = glk_get_plane_formats(dev_priv, pipe, 2588 plane_id, &num_formats); 2589 else 2590 formats = skl_get_plane_formats(dev_priv, pipe, 2591 plane_id, &num_formats); 2592 2593 if (DISPLAY_VER(dev_priv) >= 12) 2594 plane_funcs = &gen12_plane_funcs; 2595 else 2596 plane_funcs = &skl_plane_funcs; 2597 2598 if (plane_id == PLANE_1) 2599 plane_type = DRM_PLANE_TYPE_PRIMARY; 2600 else 2601 plane_type = DRM_PLANE_TYPE_OVERLAY; 2602 2603 modifiers = intel_fb_plane_get_modifiers(dev_priv, 2604 skl_get_plane_caps(dev_priv, pipe, plane_id)); 2605 2606 ret = drm_universal_plane_init(&dev_priv->drm, &plane->base, 2607 0, plane_funcs, 2608 formats, num_formats, modifiers, 2609 plane_type, 2610 "plane %d%c", plane_id + 1, 2611 pipe_name(pipe)); 2612 2613 kfree(modifiers); 2614 2615 if (ret) 2616 goto fail; 2617 2618 if (DISPLAY_VER(dev_priv) >= 12) 2619 async_modifiers = tgl_asyn_modifiers; 2620 else if (DISPLAY_VER(dev_priv) == 11) 2621 async_modifiers = icl_async_modifiers; 2622 else 2623 async_modifiers = skl_async_modifiers; 2624 2625 drm_plane_create_format_blob(&dev_priv->drm, &plane->base, > 2626 async_modifiers, sizeof(async_modifiers), 2627 intel_async_formats, 2628 sizeof(intel_async_formats), true); 2629 2630 if (DISPLAY_VER(dev_priv) >= 13) 2631 supported_rotations = DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180; 2632 else 2633 supported_rotations = 2634 DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 | 2635 DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270; 2636 2637 if (DISPLAY_VER(dev_priv) >= 11) 2638 supported_rotations |= DRM_MODE_REFLECT_X; 2639 2640 drm_plane_create_rotation_property(&plane->base, 2641 DRM_MODE_ROTATE_0, 2642 supported_rotations); 2643 2644 supported_csc = BIT(DRM_COLOR_YCBCR_BT601) | BIT(DRM_COLOR_YCBCR_BT709); 2645 2646 if (DISPLAY_VER(dev_priv) >= 10) 2647 supported_csc |= BIT(DRM_COLOR_YCBCR_BT2020); 2648 2649 drm_plane_create_color_properties(&plane->base, 2650 supported_csc, 2651 BIT(DRM_COLOR_YCBCR_LIMITED_RANGE) | 2652 BIT(DRM_COLOR_YCBCR_FULL_RANGE), 2653 DRM_COLOR_YCBCR_BT709, 2654 DRM_COLOR_YCBCR_LIMITED_RANGE); 2655 2656 drm_plane_create_alpha_property(&plane->base); 2657 drm_plane_create_blend_mode_property(&plane->base, 2658 BIT(DRM_MODE_BLEND_PIXEL_NONE) | 2659 BIT(DRM_MODE_BLEND_PREMULTI) | 2660 BIT(DRM_MODE_BLEND_COVERAGE)); 2661 2662 drm_plane_create_zpos_immutable_property(&plane->base, plane_id); 2663 2664 if (DISPLAY_VER(dev_priv) >= 12) 2665 drm_plane_enable_fb_damage_clips(&plane->base); 2666 2667 if (DISPLAY_VER(dev_priv) >= 11) 2668 drm_plane_create_scaling_filter_property(&plane->base, 2669 BIT(DRM_SCALING_FILTER_DEFAULT) | 2670 BIT(DRM_SCALING_FILTER_NEAREST_NEIGHBOR)); 2671 2672 intel_plane_helper_add(plane); 2673 2674 return plane; 2675 2676 fail: 2677 intel_plane_free(plane); 2678 2679 return ERR_PTR(ret); 2680 } 2681 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
