Re: [PATCH v4 4/5] drm/i915/dp: Compute as_sdp.vtotal based on vrr timings

["Nautiyal, Ankit K" <ankit.k.nautiyal@xxxxxxxxx>]

On 11/20/2024 2:19 PM, Mitul Golani wrote:
> Compute as_sdp.vtotal based on minimum vtotal calculated
> during vrr computation.
>
> --v2:
>   - make a separate patch and update to vmin only [Ankit].
>
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@xxxxxxxxx>
> ---
>   drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 306c00cab57e..e39ae59370c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2823,7 +2823,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
>   		as_sdp->target_rr_divider = true;
>   	} else {
>   		as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL;
> -		as_sdp->vtotal = adjusted_mode->vtotal;
> +		as_sdp->vtotal = crtc_state->vrr.vmin;

This should be changed for CMRR case also.

Regards,

Ankit

>   		as_sdp->target_rr = 0;
>   	}
>   }