> -----Original Message-----
> From: Nautiyal, Ankit K <ankit.k.nautiyal@xxxxxxxxx>
> Sent: Wednesday, November 20, 2024 4:08 PM
> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: intel-xe@xxxxxxxxxxxxxxxxxxxxx; Kandpal, Suraj <suraj.kandpal@xxxxxxxxx>;
> jani.nikula@xxxxxxxxxxxxxxx; Deak, Imre <imre.deak@xxxxxxxxx>
> Subject: [PATCH 11/12] drm/i915/dp: Make dsc helpers accept const crtc_state
> pointers
>
> Modify the dsc helpers to get max/min compressed bpp to accept `const
> struct intel_crtc_state *` pointers instead of `struct intel_crtc_state *`.
>
> These helpers are not supposed to modify `crtc_state`.
> Accepting const pointers will allow these helpers to be called from functions
> that have const pointer to crtc_state.
>
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
> drivers/gpu/drm/i915/display/intel_dp.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 6cd3ae2db1a9..1adde61c5b76 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1980,7 +1980,7 @@ static int dsc_compute_link_config(struct intel_dp
> *intel_dp,
>
> static
> u16 intel_dp_dsc_max_sink_compressed_bppx16(const struct
> intel_connector *connector,
> - struct intel_crtc_state *pipe_config,
> + const struct intel_crtc_state
> *pipe_config,
> int bpc)
> {
> u16 max_bppx16 = drm_edp_dsc_sink_output_bpp(connector-
> >dp.dsc_dpcd);
> @@ -2005,7 +2005,7 @@ u16
> intel_dp_dsc_max_sink_compressed_bppx16(const struct intel_connector
> *connec
> return 0;
> }
>
> -int intel_dp_dsc_sink_min_compressed_bpp(struct intel_crtc_state
> *pipe_config)
> +int intel_dp_dsc_sink_min_compressed_bpp(const struct intel_crtc_state
> +*pipe_config)
> {
> /* From Mandatory bit rate range Support Table 2-157 (DP v2.0) */
> switch (pipe_config->output_format) {
> @@ -2023,7 +2023,7 @@ int intel_dp_dsc_sink_min_compressed_bpp(struct
> intel_crtc_state *pipe_config) }
>
> int intel_dp_dsc_sink_max_compressed_bpp(const struct intel_connector
> *connector,
> - struct intel_crtc_state *pipe_config,
> + const struct intel_crtc_state
> *pipe_config,
> int bpc)
> {
> return intel_dp_dsc_max_sink_compressed_bppx16(connector,
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.h
> b/drivers/gpu/drm/i915/display/intel_dp.h
> index 973b2aa0da1d..eac517c1d445 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.h
> +++ b/drivers/gpu/drm/i915/display/intel_dp.h
> @@ -145,9 +145,9 @@ u16 intel_dp_dsc_get_max_compressed_bpp(struct
> drm_i915_private *i915,
> enum intel_output_format
> output_format,
> u32 pipe_bpp,
> u32 timeslots);
> -int intel_dp_dsc_sink_min_compressed_bpp(struct intel_crtc_state
> *pipe_config);
> +int intel_dp_dsc_sink_min_compressed_bpp(const struct intel_crtc_state
> +*pipe_config);
> int intel_dp_dsc_sink_max_compressed_bpp(const struct intel_connector
> *connector,
> - struct intel_crtc_state *pipe_config,
> + const struct intel_crtc_state
> *pipe_config,
> int bpc);
> u8 intel_dp_dsc_get_slice_count(const struct intel_connector *connector,
> int mode_clock, int mode_hdisplay,
> --
> 2.45.2
