Re: [PATCH i-g-t] intel-ci: Blocklist igt@i915_module_load@load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Janusz,
On 2024-11-15 at 15:58:19 +0100, Janusz Krzysztofik wrote:
> This test expects the i915 module not loaded, and it SKIPs if it finds one
> already loaded.  It was intended only for CI BAT runs as the very first
> test executed.  It's not suitable for CI runs with random test selection
> and ordering.
> 
> Since omitting it from non-BAT runs doesn't affect coverage, blocklist it
> instead of maintaining as expected SKIP.
> 
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6227
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@xxxxxxxxxxxxxxx>

Acked-by: Kamil Konieczny <kamil.konieczny@xxxxxxxxxxxxxxx>

> ---
>  tests/intel-ci/blacklist.txt | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index cfc5491d53..cdbfbcaef9 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -4,6 +4,16 @@
>  igt@xe.*
>  
>  igt@meta_test(@.*)?
> +
> +###############################################
> +# Expects the i915 module not loaded, SKIPs if one is loaded.
> +# Intended only for CI BAT runs as the very first test executed.
> +# Not suitable for CI runs with random test selection and ordering.
> +# Omitting it from non-BAT runs doesn't affect coverage, then
> +# let's blocklist it instead of maintainig as expected SKIP.
> +###############################################
> +igt@i915_module_load@load
> +
>  ###############################################
>  # Handle module reloads with great care!
>  #
> -- 
> 2.47.0
> 



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux