On Tue, 12 Nov 2024, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > On Mon, Nov 11, 2024 at 07:53:30PM +0200, Jani Nikula wrote: >> @@ -1418,7 +1422,7 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv) >> i915_active_init(&overlay->last_flip, >> NULL, intel_overlay_last_flip_retire, 0); >> >> - ret = get_registers(overlay, OVERLAY_NEEDS_PHYSICAL(dev_priv)); >> + ret = get_registers(overlay, OVERLAY_NEEDS_PHYSICAL(display)); > > I thought that you were converting the macros separately... > but if this is working, no hard feelings I only converted the ones that actually needed dev_priv, and couldn't use generics. They now accept display only. This one uses generics and can take either. > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Thanks, Jani. -- Jani Nikula, Intel
