On Mon, 11 Nov 2024, Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> wrote: > Print Vrr mode along with other vrr members in crtc_state dump. > > Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > index e2ce417b1990..abec61bb4334 100644 > --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c > @@ -296,8 +296,9 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config, > intel_dump_buffer("ELD: ", pipe_config->eld, > drm_eld_size(pipe_config->eld)); > > - drm_printf(&p, "vrr_tg: %s, vmin: %d, vmax: %d, pipeline full: %d, guardband: %d flipline: %d, vmin vblank: %d, vmax vblank: %d\n", > + drm_printf(&p, "vrr_tg: %s, mode: %d vmin: %d, vmax: %d, pipeline full: %d, guardband: %d flipline: %d, vmin vblank: %d, vmax vblank: %d\n", > str_yes_no(pipe_config->vrr.tg_enable), > + pipe_config->vrr.mode, The int in the output is meaningless. Please add a small helper to return the string. BR, Jani. > pipe_config->vrr.vmin, pipe_config->vrr.vmax, > pipe_config->vrr.pipeline_full, pipe_config->vrr.guardband, > pipe_config->vrr.flipline, -- Jani Nikula, Intel