== Series Details == Series: drm/i915/display: convert display feature helpers to struct intel_display (rev5) URL : https://patchwork.freedesktop.org/series/140886/ State : warning == Summary == Error: dim checkpatch failed 895765b7842d drm/i915/display: identify discrete graphics c2f82f26a756 drm/i915/display: convert HAS_D12_PLANE_MINIMIZATION() to struct intel_display -:36: WARNING:LONG_LINE: line length of 119 exceeds 100 columns #36: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:147: +#define HAS_D12_PLANE_MINIMIZATION(__display) ((__display)->platform.rocketlake || (__display)->platform.alderlake_s) -:36: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #36: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:147: +#define HAS_D12_PLANE_MINIMIZATION(__display) ((__display)->platform.rocketlake || (__display)->platform.alderlake_s) total: 0 errors, 1 warnings, 1 checks, 68 lines checked 9df508e1de8d drm/i915/display: convert HAS_4TILE() to struct intel_display -:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:141: +#define HAS_4TILE(__display) ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14) total: 0 errors, 0 warnings, 1 checks, 56 lines checked 687eb7ebab46 drm/i915/display: convert HAS_DOUBLE_BUFFERED_M_N() to struct intel_display -:46: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #46: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:153: +#define HAS_DOUBLE_BUFFERED_M_N(__display) (DISPLAY_VER(__display) >= 9 || (__display)->platform.broadwell) -:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #46: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:153: +#define HAS_DOUBLE_BUFFERED_M_N(__display) (DISPLAY_VER(__display) >= 9 || (__display)->platform.broadwell) total: 0 errors, 1 warnings, 1 checks, 48 lines checked 33b6f04901fa drm/i915/display: convert HAS_DP20() to struct intel_display -:149: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #149: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:156: +#define HAS_DP20(__display) ((__display)->platform.dg2 || DISPLAY_VER(__display) >= 14) total: 0 errors, 0 warnings, 1 checks, 150 lines checked 93b0cfb50560 drm/i915/display: convert HAS_GMBUS_BURST_READ() to struct intel_display -:23: WARNING:LONG_LINE: line length of 104 exceeds 100 columns #23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:165: +#define HAS_GMBUS_BURST_READ(__display) (DISPLAY_VER(__display) >= 10 || (__display)->platform.kabylake) -:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:165: +#define HAS_GMBUS_BURST_READ(__display) (DISPLAY_VER(__display) >= 10 || (__display)->platform.kabylake) total: 0 errors, 1 warnings, 1 checks, 23 lines checked 9ffb49c87c22 drm/i915/display: convert HAS_IPS() to struct intel_display -:58: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #58: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:169: +#define HAS_IPS(__display) ((__display)->platform.haswell_ult || (__display)->platform.broadwell) -:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #58: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:169: +#define HAS_IPS(__display) ((__display)->platform.haswell_ult || (__display)->platform.broadwell) total: 0 errors, 1 warnings, 1 checks, 33 lines checked cd1fd2c0750c drm/i915/display: convert HAS_MBUS_JOINING() to struct intel_display -:25: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #25: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:172: +#define HAS_MBUS_JOINING(__display) ((__display)->platform.alderlake_p || DISPLAY_VER(__display) >= 14) -:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:172: +#define HAS_MBUS_JOINING(__display) ((__display)->platform.alderlake_p || DISPLAY_VER(__display) >= 14) total: 0 errors, 1 warnings, 1 checks, 82 lines checked 1f944841d369 drm/i915/display: convert HAS_SAGV() to struct intel_display -:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #22: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:178: +#define HAS_SAGV(__display) (DISPLAY_VER(__display) >= 9 && \ + !(__display)->platform.broxton && !(__display)->platform.geminilake) -:23: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #23: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:179: + !(__display)->platform.broxton && !(__display)->platform.geminilake) total: 0 errors, 1 warnings, 1 checks, 115 lines checked 72640e6c943a drm/i915/display: convert HAS_HW_SAGV_WM() to struct intel_display -:54: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #54: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:167: +#define HAS_HW_SAGV_WM(__display) (DISPLAY_VER(__display) >= 13 && !(__display)->platform.dgfx) -:54: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #54: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:167: +#define HAS_HW_SAGV_WM(__display) (DISPLAY_VER(__display) >= 13 && !(__display)->platform.dgfx) total: 0 errors, 1 warnings, 1 checks, 161 lines checked 03a69c4bd89c drm/i915/display: convert HAS_ULTRAJOINER() to struct intel_display -:82: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #82: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:183: +#define HAS_ULTRAJOINER(__display) ((DISPLAY_VER(__display) >= 20 || \ + ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \ + HAS_DSC(__display)) -:83: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #83: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:184: + ((__display)->platform.dgfx && DISPLAY_VER(__display) == 14)) && \ total: 0 errors, 1 warnings, 1 checks, 75 lines checked a67357b16dc1 drm/i915/display: rename i915 parameter to __display in feature helpers -:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #30: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:143: +#define HAS_BIGJOINER(__display) (DISPLAY_VER(__display) >= 11 && HAS_DSC(__display)) -:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:146: +#define HAS_CUR_FBC(__display) (!HAS_GMCH(__display) && IS_DISPLAY_VER(__display, 7, 13)) -:40: WARNING:LONG_LINE: line length of 109 exceeds 100 columns #40: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:148: +#define HAS_DBUF_OVERLAP_DETECTION(__display) (DISPLAY_RUNTIME_INFO(__display)->has_dbuf_overlap_detection) -:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #62: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:160: +#define HAS_DSC_MST(__display) (DISPLAY_VER(__display) >= 12 && HAS_DSC(__display)) -:94: WARNING:LONG_LINE: line length of 106 exceeds 100 columns #94: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:180: +#define HAS_TRANSCODER(__display, trans) ((DISPLAY_RUNTIME_INFO(__display)->cpu_transcoder_mask & \ -:117: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #117: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:195: +#define IS_DISPLAY_VERx100(__display, from, until) ( \ BUILD_BUG_ON_ZERO((from) < 200) + \ + (DISPLAY_VERx100(__display) >= (from) && \ + DISPLAY_VERx100(__display) <= (until))) -:117: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'from' - possible side-effects? #117: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:195: +#define IS_DISPLAY_VERx100(__display, from, until) ( \ BUILD_BUG_ON_ZERO((from) < 200) + \ + (DISPLAY_VERx100(__display) >= (from) && \ + DISPLAY_VERx100(__display) <= (until))) -:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #141: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:215: +#define IS_DISPLAY_VERx100_STEP(__display, ipver, from, until) \ + (IS_DISPLAY_VERx100((__display), (ipver), (ipver)) && \ + IS_DISPLAY_STEP((__display), (from), (until))) -:141: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ipver' - possible side-effects? #141: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:215: +#define IS_DISPLAY_VERx100_STEP(__display, ipver, from, until) \ + (IS_DISPLAY_VERx100((__display), (ipver), (ipver)) && \ + IS_DISPLAY_STEP((__display), (from), (until))) -:156: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #156: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:223: +#define DISPLAY_VERx100(__display) (DISPLAY_RUNTIME_INFO(__display)->ip.ver * 100 + \ + DISPLAY_RUNTIME_INFO(__display)->ip.rel) -:158: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #158: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:225: +#define IS_DISPLAY_VER(__display, from, until) \ + (DISPLAY_VER(__display) >= (from) && DISPLAY_VER(__display) <= (until)) -:167: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__display' - possible side-effects? #167: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:230: +#define IS_DISPLAY_STEP(__display, since, until) \ + (drm_WARN_ON(__to_intel_display(__display)->drm, INTEL_DISPLAY_STEP(__display) == STEP_NONE), \ + INTEL_DISPLAY_STEP(__display) >= (since) && INTEL_DISPLAY_STEP(__display) < (until)) -:168: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #168: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:231: + (drm_WARN_ON(__to_intel_display(__display)->drm, INTEL_DISPLAY_STEP(__display) == STEP_NONE), \ total: 0 errors, 3 warnings, 10 checks, 151 lines checked 77e1c5ebd773 drm/i915/display: convert display device identification to struct intel_display 1f70ed539e6a drm/i915/display: pass struct pci_dev * to intel_display_device_probe() ab6853526ac5 drm/i915/display: add mobile platform group -:119: WARNING:LONG_LINE_COMMENT: line length of 134 exceeds 100 columns #119: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:479: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */ -:156: WARNING:LONG_LINE_COMMENT: line length of 134 exceeds 100 columns #156: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:504: + .__runtime_defaults.port_mask = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) | BIT(PORT_D), /* DP A, SDVO/HDMI/DP B, HDMI/DP C/D */ total: 0 errors, 2 warnings, 0 checks, 180 lines checked
