On Thu, 07 Nov 2024, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > The ADPA_DPMS bit definitions aer just an alias for the *are > sync disable bits, and unused one at that. Drop the > pointless definitions. Pedantic mode, there's some singular/plural asymmetry going on here. :p Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_reg.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index c160e087972a..f0757c4491f1 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -1188,11 +1188,6 @@ > #define ADPA_VSYNC_ACTIVE_LOW 0 > #define ADPA_HSYNC_ACTIVE_HIGH (1 << 3) > #define ADPA_HSYNC_ACTIVE_LOW 0 > -#define ADPA_DPMS_MASK (~(3 << 10)) > -#define ADPA_DPMS_ON (0 << 10) > -#define ADPA_DPMS_SUSPEND (1 << 10) > -#define ADPA_DPMS_STANDBY (2 << 10) > -#define ADPA_DPMS_OFF (3 << 10) > > /* Hotplug control (945+ only) */ > #define PORT_HOTPLUG_EN(dev_priv) _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x61110) -- Jani Nikula, Intel
