>> > That's the part that I'm not sure if I agree. if I remember from some >> > experiments in the past, >> > when you call to wake up the child, the parent will wakeup first anyway. >> > >> The child (mtd device) does not exist at this point of time. >> To create MTD device, the partition table should be provided >> and it read directly from flash that should be powered to do read. > > I don't understand... you have the mtd->dev at this point... this is > the one you should be touching, not the mtd->dev.parent... even at the > probe, but moreover on everywhere else as well. > >> >> > > Considering above, is this move is justified? >> > > Also, MTD drivers tend to enable parent rpm, not its own one. >> > >> > What other drivers are you looking for reference? >> >> drivers/mtd/nand/raw/tegra_nand.c >> drivers/mtd/nand/raw/renesas-nand-controller.c >> drivers/mtd/maps/physmap-core.c > > I see they getting pdev->dev... not the parent... That's three drivers where there is probably room for improvement. These differences are subtle and likely un-catch during review. Feel free to correct the drivers if you think they are wrong and more importantly, do the correct thing in your own. Thanks, Miquèl
