On Wed, 06 Nov 2024, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > I just wanted to defuse the mess around struct > edp_power_seq, but ended up super confused by the PPS > delay initialization code and so ended up untangling > some of that mess as well. Thanks, this was long overdue, nice cleanup. The one thing I missed (that could be added on top) was units in the debug logs, 100 us for struct intel_pps_delays, and ms for struct intel_pps *_delay members. BR, Jani > > Ville Syrjälä (8): > drm/i915/pps: Store the power cycle delay without the +1 > drm/i915/pps: Decouple pps delays from VBT struct definition > drm/i915/pps: Rename intel_pps_delay members > drm/i915/lvds: Use struct intel_pps_delays for LVDS power sequencing > drm/i915/pps: Spell out the eDP spec power sequencing delays a bit > more clearly > drm/i915/pps: Extract msecs_to_pps_units() > drm/i915/pps: Extract pps_units_to_msecs() > drm/i915/pps: Eliminate pointless get_delay() macro > > drivers/gpu/drm/i915/display/intel_bios.c | 15 +- > drivers/gpu/drm/i915/display/intel_bios.h | 8 - > .../drm/i915/display/intel_display_types.h | 15 +- > drivers/gpu/drm/i915/display/intel_dp_aux.c | 1 - > drivers/gpu/drm/i915/display/intel_lvds.c | 49 +++--- > drivers/gpu/drm/i915/display/intel_pps.c | 149 ++++++++++-------- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 8 + > 7 files changed, 136 insertions(+), 109 deletions(-) -- Jani Nikula, Intel
