== Series Details == Series: Refactor MST DSC Determination Policy (rev2) URL : https://patchwork.freedesktop.org/series/140832/ State : warning == Summary == Error: dim checkpatch failed acf8c5365f33 drm/display/dsc: Refactor DRM MST DSC Determination Policy -:11: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #11: in drm_dp_mst_is_virtual_dpcd() is not always correct. There are DP1.4 products -:164: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #164: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6061: + drm_info(mgr->dev, "MST_DSC check port %p for dsc decompression capability\n", port); -:193: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #193: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6071: + drm_info(mgr->dev, "MST_DSC check immediate_upstream_port %p for dsc passthrough capability\n", + immediate_upstream_port); -:211: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #211: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6084: + if (endpoint_dsc & DP_DSC_DECOMPRESSION_IS_SUPPORTED && + upstream_dsc & DP_DSC_PASSTHROUGH_IS_SUPPORTED) { -:251: CHECK:BRACES: braces {} should be used on all arms of this statement #251: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6108: + if (endpoint_dsc & DP_DSC_DECOMPRESSION_IS_SUPPORTED) [...] + else { [...] -:253: CHECK:BRACES: Unbalanced braces around else statement #253: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6110: + else { -:264: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #264: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6118: + drm_info(mgr->dev, "MST_DSC topology with multiple mstbs, dsc decompression at immediate_upstream_port %p\n", + dsc_port); -:279: WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns #279: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6131: + /* read fec cap one more time in case fec not capable return from enum path result */ -:280: WARNING:LONG_LINE: line length of 102 exceeds 100 columns #280: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6132: + if ((drm_dp_dpcd_read(&fec_port->aux, DP_FEC_CAPABILITY, &fec_cap, 1) != 1) || -:281: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #281: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6133: + if ((drm_dp_dpcd_read(&fec_port->aux, DP_FEC_CAPABILITY, &fec_cap, 1) != 1) || + !(fec_cap & DP_FEC_CAPABLE)) { -:282: WARNING:LONG_LINE: line length of 112 exceeds 100 columns #282: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6134: + drm_err(mgr->dev, "MST_DSC Failed to retrieve fec caps at port %p\n", fec_port); -:300: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #300: FILE: drivers/gpu/drm/display/drm_dp_mst_topology.c:6145: + if ((drm_dp_dpcd_read(mgr->aux, DP_FEC_CAPABILITY, &fec_cap, 1) != 1) || + !(fec_cap & DP_FEC_CAPABLE)) { total: 0 errors, 5 warnings, 7 checks, 294 lines checked c38ecc6747e8 drm/display/dsc: MST DSC Interface Change -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7: Starting from dp2 where dsc passthrough is introduced, it is required to identify -:132: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #132: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c:262: + if (drm_dp_dpcd_read(aconnector->mst_output_port->dsc_aux, DP_DSC_SUPPORT, dsc_caps, 16) < 0) -:137: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #137: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c:266: + if (drm_dp_dpcd_read(aconnector->mst_output_port->dsc_aux, DP_DSC_BRANCH_OVERALL_THROUGHPUT_0, dsc_branch_dec_caps_raw, 3) == 3) -:149: WARNING:LONG_LINE: line length of 121 exceeds 100 columns #149: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c:285: + if (drm_dp_dpcd_read(aconnector->mst_output_port->dsc_aux, DP_DOWNSTREAMPORT_PRESENT, &ds_port_present, 1) < 0) { total: 0 errors, 3 warnings, 1 checks, 268 lines checked
