On Tue, 29 Oct 2024, "Hogander, Jouni" <jouni.hogander@xxxxxxxxx> wrote: > On Tue, 2024-10-29 at 11:25 +0200, Jani Nikula wrote: >> It's misleading to use the same sideband mutex for LPT/WPT IOSF, >> VLV/CHV >> IOSF, and punit. Add dedicated locks for clarity. > > For the whole series: > > Reviewed-by: Jouni Högander <jouni.hogander@xxxxxxxxx> Thanks for the review, pushed to din. BR, Jani. > >> >> Jani Nikula (4): >> drm/i915/sbi: add intel_sbi_{lock,unlock}() >> drm/i915/sbi: add a dedicated mutex for LPT/WPT IOSF sideband >> drm/i915: add a dedicated mutex for VLV/CHV IOSF sideband >> drm/i915: hide VLV PUNIT IOSF sideband qos handling better >> >> .../gpu/drm/i915/display/intel_pch_refclk.c | 26 ++++++++--------- >> drivers/gpu/drm/i915/i915_driver.c | 8 ++++-- >> drivers/gpu/drm/i915/i915_drv.h | 10 ++++++- >> drivers/gpu/drm/i915/intel_sbi.c | 22 ++++++++++++++- >> drivers/gpu/drm/i915/intel_sbi.h | 4 +++ >> drivers/gpu/drm/i915/vlv_sideband.c | 28 +++++++++++++++-- >> -- >> drivers/gpu/drm/i915/vlv_sideband.h | 3 ++ >> 7 files changed, 79 insertions(+), 22 deletions(-) >> > -- Jani Nikula, Intel