> -----Original Message----- > From: Jadav, Raag <raag.jadav@xxxxxxxxx> > Sent: Thursday, 31 October 2024 17.13 > To: Kahola, Mika <mika.kahola@xxxxxxxxx> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Sousa, Gustavo <gustavo.sousa@xxxxxxxxx>; > jani.nikula@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 1/2] drm/i915/xe3lpd: Power request > asserting/deasserting > > On Thu, Oct 31, 2024 at 04:50:20PM +0200, Raag Jadav wrote: > > On Thu, Oct 31, 2024 at 07:59:16PM +0530, Kahola, Mika wrote: > > > > ... > > > > > > > +static void wa_14020908590(struct intel_display *display, > > > > > + bool enable) > > > > > > > > Can be one line? > > > > > > Could be. This should fit within expected line length. > > > > With that, > > > > Reviewed-by: Raag Jadav <raag.jadav@xxxxxxxxx> > > Btw, this looks like a v4 with missing changelogs. > So make sure to update it too. Right. I forgot to add that. I will update the changes and maybe send to once again to the mailing list so CI can run it once more. > > Raag
