On Wed, 30 Oct 2024, "Kandpal, Suraj" <suraj.kandpal@xxxxxxxxx> wrote: >> -----Original Message----- >> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani >> Nikula >> Sent: Tuesday, October 29, 2024 9:26 PM >> To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx >> Cc: Nikula, Jani <jani.nikula@xxxxxxxxx>; ville.syrjala@xxxxxxxxxxxxxxx; Roper, >> Matthew D <matthew.d.roper@xxxxxxxxx>; De Marchi, Lucas >> <lucas.demarchi@xxxxxxxxx> >> Subject: [PATCH v3] drm/i915/display: use x100 version for full version and >> release >> >> Use x100, or ver * 100 + rel, versions for full IP version checks, similar to what >> xe driver does: >> >> - Replace IP_VER(14, 1) inline with 1401, etc. >> >> - Convert DISPLAY_VER_FULL() to DISPLAY_VERx100() >> >> - Convert IS_DISPLAY_VER_FULL() to IS_DISPLAY_VERx100() >> >> - Convert IS_DISPLAY_VER_STEP() to IS_DISPLAY_VERx100_STEP() >> >> This makes ver.rel versions easier to use, follows the xe driver pattern, and >> drops the dependency on the IP_VER() macro. >> >> v2: Rebase, drop IP_VER() from xe compat headers >> >> v3: Rebase >> >> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> >> Acked-by: Matt Roper <matthew.d.roper@xxxxxxxxx> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > LGTM, > Reviewed-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx> Thanks for the review, pushed to din. BR, Jani. -- Jani Nikula, Intel
