Re: [PATCH] drm/i915/display: use x100 version for full version and release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2024 at 07:58:29AM -0700, Matt Roper wrote:
On Fri, Oct 25, 2024 at 11:49:34AM +0300, Jani Nikula wrote:
On Fri, 25 Oct 2024, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> On Thu, Oct 24, 2024 at 08:11:04PM +0300, Jani Nikula wrote:
>> Use x100, or ver * 100 + rel, versions for full IP version checks,
>
> Have the hardware folks promised to never use minor >= 100?

I guess that's a fair point. Xe uses this extensively, and would be
hosed as well. Matt, Rodrigo?

I was pretty concerned about this as well back in early Xe development
and raised it as code review feedback at the time, but the consensus was
"let's just deal with that if/when it truly becomes a problem."  MTL/ARL
were already up in the 12.70's  for release version so it did feel like
we might see the release number go above 100 if too many more platforms
came out.

But now that we've moved on to Xe2 and Xe3 and hardware seem to be
moving the major IP version by 10 for every family (20 -> 30 for Xe2 to
Xe3) that does give them a lot breathing room to insert derivative and
refresh platforms and it seems less likely we'll ever see release
numbers get as high as they did in the 12.xx era.  So I'm not too
concerned about this anymore.

I didn't review carefully to make sure the patch caught all the
necessary conversions, but

and it's also used by mesa (they actually use VERx10). If HW people have
the brilliant idea of using something above 100, we have at least 2
projects to try to convince them that's a bad idea :)

Lucas De Marchi



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux