On Fri, Oct 25, 2024 at 04:28:18AM +0000, Murthy, Arun R wrote: > > > Subject: Re: [PATCH] drm/i915/display: plane property for async > > > supported modifiers > > > > > > On Wed, Oct 16, 2024 at 04:54:09PM +0300, Ville Syrjälä wrote: > > > > On Wed, Oct 16, 2024 at 04:30:19PM +0300, Ville Syrjälä wrote: > > > > > On Wed, Oct 16, 2024 at 11:06:26AM +0530, Arun R Murthy wrote: > > > > > > Create a i915 private plane property for sharing the async > > > > > > supported modifiers to the user. > > > > > > UMD related discussion requesting the same > > > > > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618# > > > > > > no > > > > > > te_2487123 > > > > > > > > > > > > Signed-off-by: Arun R Murthy <arun.r.murthy@xxxxxxxxx> > > > > > > --- > > > > > > .../gpu/drm/i915/display/intel_atomic_plane.c | 6 +++ > > > > > > .../drm/i915/display/intel_display_types.h | 4 ++ > > > > > > .../drm/i915/display/skl_universal_plane.c | 49 > > ++++++++++++++++++- > > > > > > > > > > This whole thing belongs in the drm core. > > > > > > > > And I don't even see an actual implementation of anything here. > > > > Why did you even post this when it doesn't do anything? > > > > > > > > Anyways, thinking about how we might actually implement this, we can > > > > probably leverage > > > > https://patchwork.freedesktop.org/patch/619047/?series=139807&rev=3 > > > > > > Although we should probably pass the format to that as well... > > > > > The blob points to the struct with elements, modifier and formats. > > The main intention of this patch to get the i915 plane private property. > > The reason for not having this as drm property is we are the only user for this > > and no other vendor has this restriction. > > > > Any comments on this? Seeinag as the patch does nothing so there is nothing to comment beyond what I already said. -- Ville Syrjälä Intel
