On Tue, Oct 22, 2024 at 12:59:20PM +0530, Suraj Kandpal wrote:
> Add check to remove HDCP2 compatibility from BMG as it does not
> have GSC which ends up causing warning when we try to get reference
> of GSC FW.
Why do you say BMG doesn't have GSC? I don't see anything in the bspec
indicating it wouldn't have it.
If you're missing the GSC firmware, then we'll disable the engine, but
that's true on any platform.
Matt
>
> Fixes: 89d030804831 ("drm/xe/hdcp: Fix condition for hdcp gsc cs requirement")
> Fixes: 883631771038 ("drm/i915/mtl: Add HDCP GSC interface")
> Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 3 ++-
> drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 4 +++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> index 55965844d829..2c1d0ee8cec2 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> @@ -21,7 +21,8 @@ struct intel_hdcp_gsc_message {
>
> bool intel_hdcp_gsc_cs_required(struct intel_display *display)
> {
> - return DISPLAY_VER(display) >= 14;
> + return DISPLAY_VER(display) >= 14 &&
> + DISPLAY_VER_FULL(display) != IP_VER(14, 1);
> }
>
> bool intel_hdcp_gsc_check_status(struct intel_display *display)
> diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> index 231677129a35..efa3441c249c 100644
> --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> @@ -8,6 +8,7 @@
> #include <linux/delay.h>
>
> #include "abi/gsc_command_header_abi.h"
> +#include "i915_drv.h"
> #include "intel_hdcp_gsc.h"
> #include "intel_hdcp_gsc_message.h"
> #include "xe_bo.h"
> @@ -32,7 +33,8 @@ struct intel_hdcp_gsc_message {
>
> bool intel_hdcp_gsc_cs_required(struct intel_display *display)
> {
> - return DISPLAY_VER(display) >= 14;
> + return DISPLAY_VER(display) >= 14 &&
> + DISPLAY_VER_FULL(display) != IP_VER(14, 1);
> }
>
> bool intel_hdcp_gsc_check_status(struct intel_display *display)
> --
> 2.34.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
