On Wed, Oct 23, 2024 at 04:09:03PM +0300, Jani Nikula wrote: > On Tue, 22 Oct 2024, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: > > On Mon, Oct 21, 2024 at 04:54:09PM +0300, Jani Nikula wrote: > >> @@ -1466,7 +1462,7 @@ find_subplatform_desc(struct pci_dev *pdev, const struct platform_desc *desc) > >> const struct subplatform_desc *sp; > >> const u16 *id; > >> > >> - for (sp = desc->subplatforms; sp && sp->subplatform; sp++) > >> + for (sp = desc->subplatforms; sp && sp->pciidlist; sp++) > > > > I honestly got confused on this... should it be a separate patch? > > Well, I'm removing ->subplatform so obviously I have to check for the > end condition using something else. I can make it a separate patch if > you want. oh, okay... I was in doubt if pciidlist was the right check to ensure same condition. But taking a deeper look on it here again it indeed sounds the case. Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > BR, > Jani. > > > -- > Jani Nikula, Intel
