== Series Details == Series: pmu changes URL : https://patchwork.freedesktop.org/series/140350/ State : warning == Summary == Error: dim checkpatch failed 95db02e7c02a pmu changes -:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/pmu-unregister -:39: WARNING:TABSTOP: Statements should start on a tabstop #39: FILE: include/linux/idr.h:137: + if (_T.id >= 0) idr_remove(_T.idr, _T.id), -:39: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #39: FILE: include/linux/idr.h:137: + if (_T.id >= 0) idr_remove(_T.idr, _T.id), -:41: ERROR:CODE_INDENT: code indent should use tabs where possible #41: FILE: include/linux/idr.h:139: +^I ^I.idr = idr,$ -:41: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #41: FILE: include/linux/idr.h:139: +^I ^I.idr = idr,$ -:57: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #57: FILE: include/linux/perf_event.h:321: + spinlock_t events_lock; -:140: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #140: FILE: include/linux/perf_event.h:1113: +extern int perf_pmu_unregister(struct pmu *pmu); -:170: WARNING:LINE_SPACING: Missing a blank line after declarations #170: FILE: kernel/events/core.c:1196: + int *count = &(*this_cpu_ptr(pmu->cpu_pmu_context))->pmu_disable_count; + WARN_ON_ONCE(*count == 0); -:504: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #504: FILE: kernel/events/core.c:5403: +DEFINE_FREE(__free_event, struct perf_event *, if (_T) __free_event(_T)) [...] +static void _free_event(struct perf_event *event) -:544: WARNING:BRACES: braces {} are not necessary for any arm of this statement #544: FILE: kernel/events/core.c:5548: + if (event->state > PERF_EVENT_STATE_REVOKED) { [...] + } else { [...] -:545: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV) #545: FILE: kernel/events/core.c:5549: + perf_remove_from_context(event, DETACH_GROUP|DETACH_DEAD); ^ -:770: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #770: FILE: kernel/events/core.c:11869: +DEFINE_FREE(pmu_unregister, struct pmu *, if (_T) perf_pmu_free(_T)) [...] +int perf_pmu_register(struct pmu *_pmu, const char *name, int type) -:1145: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #1145: FILE: kernel/events/core.c:12498: + return (void*)pmu; total: 3 errors, 7 warnings, 3 checks, 1214 lines checked
