Hi, On Tue, 8 Oct 2024, Vinod Govindapillai wrote: > After pruning the sad audio frequency list, if there are no > supported audio frequencies left, audio cannot be supported. > So mark has_audio accordingly. [...] > @@ -823,9 +824,13 @@ bool intel_audio_compute_eld_config(struct drm_connector_state *conn_state, > "SAD updated. Freq: 0x%x(0x%x) Channels: %d(%d)\n", > sad.freq, sad_freq, sad.channels, sad_channels); > } > + > + /* If no supported freq in any sads, make audio support to false */ > + audio_supported |= sad.freq; With the boolean logic fixed (Jani's note): Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx> > - return true; > + drm_dbg_kms(&i915->drm, "audio supported: %d\n", audio_supported); > + return audio_supported; I was wondering whether this would warrant a more prominent warning, but I guess if such a (rare) case would be hit, this message would be emitted all the time, so probably still best left as a debug level message. Br, Kai
