RE: [PATCH 27/31] drm/xe/display: Notify opregion upon runtime suspend/resume non-d3cold

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----Original Message-----
From: Intel-xe <intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Rodrigo Vivi
Sent: Tuesday, September 24, 2024 1:36 PM
To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx
Cc: Deak, Imre <imre.deak@xxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>
Subject: [PATCH 27/31] drm/xe/display: Notify opregion upon runtime suspend/resume non-d3cold
> 
> Opregion needs to be notified about the power transition even when
> not going to d3cold. This aligns with i915 sequence.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

LGTM.

Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 44cace0237dd..780c8d7f392d 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -447,6 +447,8 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe)
>  
>  	if (xe->d3cold.allowed)
>  		intel_display_power_suspend_late(xe, false);
> +	else
> +		intel_opregion_notify_adapter(&xe->display, PCI_D1);
>  
>  	intel_hpd_poll_enable(xe);
>  }
> @@ -458,6 +460,8 @@ void xe_display_pm_runtime_resume_early(struct xe_device *xe)
>  
>  	if (xe->d3cold.allowed)
>  		intel_display_power_resume_early(xe);
> +	else
> +		intel_opregion_notify_adapter(&xe->display, PCI_D0);
>  }
>  
>  void xe_display_pm_runtime_resume(struct xe_device *xe)
> -- 
> 2.46.0
> 
> 




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux