-----Original Message-----
From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Rodrigo Vivi
Sent: Tuesday, September 24, 2024 1:36 PM
To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-xe@xxxxxxxxxxxxxxxxxxxxx
Cc: Deak, Imre <imre.deak@xxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; Gupta, Anshuman <anshuman.gupta@xxxxxxxxx>; Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Subject: [PATCH 12/31] drm/i915: Remove lingering pci_save_state
>
> The pairing pci_restore_state was removed by commit
> 'b7e53aba2f0e ("drm/i915: remove restore in resume")'
> to fix a hardware hang in resume.
>
> Furthermore, it looks like PCI subsystem should be taking care
> of the save and restore here.
>
> Remove the lingering/stand-alone pci_save_state call.
>
> Cc: Anshuman Gupta <anshuman.gupta@xxxxxxxxx>
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
LGTM. Though the wording of the commit message may
initially confuse some people (me) into thinking
pci_save_state is now unused and can have its definition
removed, which is not the case. I can't think of any
better alternatives, though, so I won't block on it.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
-Jonathan Cavitt
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index ce2dd03136d3..4fc9d8bce1fd 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -1008,8 +1008,6 @@ static int i915_drm_suspend(struct drm_device *dev)
> intel_display_driver_disable_user_access(dev_priv);
> }
>
> - pci_save_state(pdev);
> -
> intel_display_driver_suspend(dev_priv);
>
> intel_irq_suspend(dev_priv);
> --
> 2.46.0
>
>
