RE: [PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----Original Message-----
From: Intel-xe <intel-xe-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Imre Deak
Sent: Monday, October 7, 2024 7:06 AM
To: intel-xe@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>
Subject: [PATCH 2/2] drm/xe: Add missing HPD interrupt enabling during non-d3cold RPM resume
> 
> Atm the display HPD interrupts that got disabled during runtime
> suspend, are re-enabled only if d3cold is enabled. Fix things by
> also re-enabling the interrupts if d3cold is disabled.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx>

Is there a reason this ended up as a separate patch?
Not blocking, just curious.
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@xxxxxxxxx>
-Jonathan Cavitt

> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index cb2449b7921ac..695c27ac6b0f8 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -486,6 +486,7 @@ void xe_display_pm_runtime_resume(struct xe_device *xe)
>  		return;
>  	}
>  
> +	intel_hpd_init(xe);
>  	intel_hpd_poll_disable(xe);
>  }
>  
> -- 
> 2.44.2
> 
> 




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux