You can consider using max rather than ?: See lines 178 and 180. julia ---------- Forwarded message ---------- Date: Wed, 2 Oct 2024 11:11:36 +0800 From: kernel test robot <lkp@xxxxxxxxx> To: oe-kbuild@xxxxxxxxxxxxxxx Cc: lkp@xxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxxx> Subject: Re: [PATCHv2] drm/i915/dp: Guarantee a minimum HBlank time BCC: lkp@xxxxxxxxx CC: oe-kbuild-all@xxxxxxxxxxxxxxx In-Reply-To: <20241001074348.2193502-1-arun.r.murthy@xxxxxxxxx> References: <20241001074348.2193502-1-arun.r.murthy@xxxxxxxxx> TO: Arun R Murthy <arun.r.murthy@xxxxxxxxx> TO: intel-xe@xxxxxxxxxxxxxxxxxxxxx TO: intel-gfx@xxxxxxxxxxxxxxxxxxxxx CC: Arun R Murthy <arun.r.murthy@xxxxxxxxx> Hi Arun, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on linus/master v6.12-rc1 next-20241001] [cannot apply to drm-intel/for-linux-next-fixes drm-tip/drm-tip] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-i915-dp-Guarantee-a-minimum-HBlank-time/20241001-155536 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/20241001074348.2193502-1-arun.r.murthy%40intel.com patch subject: [PATCHv2] drm/i915/dp: Guarantee a minimum HBlank time :::::: branch date: 19 hours ago :::::: commit date: 19 hours ago config: x86_64-randconfig-104-20241002 (https://download.01.org/0day-ci/archive/20241002/202410021032.BpJez1ja-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Julia Lawall <julia.lawall@xxxxxxxx> | Closes: https://lore.kernel.org/r/202410021032.BpJez1ja-lkp@xxxxxxxxx/ cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/i915/display/intel_dp_mst.c:178:32-33: WARNING opportunity for max() drivers/gpu/drm/i915/display/intel_dp_mst.c:180:32-33: WARNING opportunity for max() vim +178 drivers/gpu/drm/i915/display/intel_dp_mst.c 9069b77545ca5a Imre Deak 2023-11-17 158 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 159 static void intel_dp_mst_compute_min_hblank(struct intel_crtc_state *crtc_state, 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 160 struct intel_connector *intel_connector, 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 161 int bpp_x16) 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 162 { 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 163 struct intel_encoder *intel_encoder = intel_connector->encoder; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 164 struct intel_dp_mst_encoder *intel_mst = enc_to_mst(intel_encoder); 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 165 struct intel_dp *intel_dp = &intel_mst->primary->dp; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 166 struct intel_display *intel_display = to_intel_display(intel_encoder); 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 167 const struct drm_display_mode *adjusted_mode = 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 168 &crtc_state->hw.adjusted_mode; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 169 u32 symbol_size = intel_dp_is_uhbr(crtc_state) ? 32 : 8; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 170 u32 hblank; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 171 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 172 if (DISPLAY_VER(intel_display) < 20) 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 173 return; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 174 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 175 /* Calculate min Hblank Link Layer Symbol Cycle Count for 8b/10b MST & 128b/132b */ 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 176 hblank = DIV_ROUND_UP((DIV_ROUND_UP(adjusted_mode->htotal - adjusted_mode->hdisplay, 4) * bpp_x16), symbol_size); 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 177 if (intel_dp_is_uhbr(crtc_state)) 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 @178 intel_dp->min_hblank = hblank > 5 ? hblank : 5; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 179 else 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 180 intel_dp->min_hblank = hblank > 3 ? hblank : 3; 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 181 } 9ffe2a8e0d3097 Arun R Murthy 2024-10-01 182 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
