On Mon, 23 Sep 2024, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Mon, Sep 23, 2024 at 05:35:23PM +0300, Raag Jadav wrote: >> On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: >> > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > ... > >> > > +extern const char *const wedge_recovery_opts[]; >> > >> > It's not NULL terminated. How users will know that they have an index valid? >> >> It's expected to be accessed using recovery_*() helpers. > > If so, this has to be static then. Yeah, please make the helpers regular functions. Static inlines are just harmful here. BR, Jani. > >> > Either you NULL-terminate that, or export the size as well (personally I would >> > go with the first approach). -- Jani Nikula, Intel
