✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: clean up DP testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm/i915/dp: clean up DP testing
URL   : https://patchwork.freedesktop.org/series/138919/
State : warning

== Summary ==

Error: dim checkpatch failed
ac153ee52cb9 drm/i915/dp: split out intel_dp_test.[ch] to a dedicated file
-:638: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#638: 
new file mode 100644

-:674: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#674: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:32:
+		limits->pipe.min_bpp = limits->pipe.max_bpp = bpp;

-:693: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#693: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:51:
+				limits->min_rate = limits->max_rate =

-:695: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#695: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:53:
+			limits->min_lane_count = limits->max_lane_count =

-:814: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!intel_connector->detect_edid"
#814: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:172:
+	if (intel_connector->detect_edid == NULL ||

-:825: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#825: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:183:
+		if (intel_dp->aux.i2c_nack_count > 0 ||
+			intel_dp->aux.i2c_defer_count > 0)

total: 0 errors, 1 warnings, 5 checks, 1112 lines checked
0daef0baa4d8 drm/i915/dp: fix style issues in intel_dp_test.c
29c064d82250 drm/i915/dp: convert intel_dp_test.c struct intel_display
5faac5331e48 drm/i915/dp: clean up intel_dp_test.[ch] interface
70b53759c3f5 drm/i915/dp: move DP test debugfs files next to the functionality
-:339: CHECK:BRACES: braces {} should be used on all arms of this statement
#339: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:591:
+		if (encoder && connector->status == connector_status_connected) {
[...]
+		} else
[...]

-:345: CHECK:BRACES: Unbalanced braces around else statement
#345: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:597:
+		} else

-:388: CHECK:BRACES: braces {} should be used on all arms of this statement
#388: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:640:
+		if (encoder && connector->status == connector_status_connected) {
[...]
+		} else
[...]

-:413: CHECK:BRACES: Unbalanced braces around else statement
#413: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:665:
+		} else

-:441: CHECK:BRACES: braces {} should be used on all arms of this statement
#441: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:693:
+		if (encoder && connector->status == connector_status_connected) {
[...]
+		} else
[...]

-:444: CHECK:BRACES: Unbalanced braces around else statement
#444: FILE: drivers/gpu/drm/i915/display/intel_dp_test.c:696:
+		} else

total: 0 errors, 0 warnings, 6 checks, 460 lines checked
874b16c45faf drm/i915/dp: fix style issues in DP test debugfs
745fb3b3e2a8 drm/i915/display: remove the loop in fifo underrun debugfs file creation
fa22231860a4 drm/i915/dp: convert DP test debugfs to struct intel_display
85c872630450 drm/i915/dp: add intel_dp_test_reset() and intel_dp_test_short_pulse()





[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux