Re: [PATCH v6 02/12] spi: intel-dg: implement region enumeration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 16, 2024 at 04:49:18PM +0300, Alexander Usyskin wrote:

> In intel-dg spi, there is no access to the spi controller,
> the information is extracted from the descriptor region.

Which information?  I can't tell what this patch is supposed to do; as
with the first patch this shouldn't be standalone.

> +static inline u32 spi_error(struct intel_dg_spi *spi)
> +{

> +static inline u32 spi_read32(struct intel_dg_spi *spi, u32 address)
> +{

At least these names are too generic, please use driver specific
prefixes.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux