== Series Details == Series: Modify iterators to prepare for ultrajoiner (rev2) URL : https://patchwork.freedesktop.org/series/138751/ State : warning == Summary == Error: dim checkpatch failed 3bd49f072949 drm/i915: Add some essential functionality for joiners be1cfc9d7b74 drm/i915/display: Enhance iterators for modeset en/disable -:203: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #203: FILE: drivers/gpu/drm/i915/display/intel_display.h:395: +#define for_each_crtc_in_masks(display, crtc, first_pipes, second_pipes, i) \ + for ((i) = 0; \ + (i) < (I915_MAX_PIPES * 2) && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \ + (i)++) \ + for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i)) -:203: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #203: FILE: drivers/gpu/drm/i915/display/intel_display.h:395: +#define for_each_crtc_in_masks(display, crtc, first_pipes, second_pipes, i) \ + for ((i) = 0; \ + (i) < (I915_MAX_PIPES * 2) && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \ + (i)++) \ + for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i)) -:205: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #205: FILE: drivers/gpu/drm/i915/display/intel_display.h:397: + (i) < (I915_MAX_PIPES * 2) && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \ -:209: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc' - possible side-effects? #209: FILE: drivers/gpu/drm/i915/display/intel_display.h:401: +#define for_each_crtc_in_masks_reverse(display, crtc, first_pipes, second_pipes, i) \ + for ((i) = (I915_MAX_PIPES * 2 - 1); \ + (i) >= 0 && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \ + (i)--) \ + for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i)) -:209: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #209: FILE: drivers/gpu/drm/i915/display/intel_display.h:401: +#define for_each_crtc_in_masks_reverse(display, crtc, first_pipes, second_pipes, i) \ + for ((i) = (I915_MAX_PIPES * 2 - 1); \ + (i) >= 0 && ((crtc) = intel_crtc_for_pipe(display, (i) % I915_MAX_PIPES), 1); \ + (i)--) \ + for_each_if((crtc) && ((first_pipes) | ((second_pipes) << I915_MAX_PIPES)) & BIT(i)) -:215: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc_state' - possible side-effects? #215: FILE: drivers/gpu/drm/i915/display/intel_display.h:407: +#define for_each_pipe_crtc_modeset_disable(display, crtc, crtc_state, i) \ + for_each_crtc_in_masks(display, crtc, \ + _intel_modeset_primary_pipes(crtc_state), \ + _intel_modeset_secondary_pipes(crtc_state), \ + i) -:221: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'crtc_state' - possible side-effects? #221: FILE: drivers/gpu/drm/i915/display/intel_display.h:413: +#define for_each_pipe_crtc_modeset_enable(display, crtc, crtc_state, i) \ + for_each_crtc_in_masks_reverse(display, crtc, \ + _intel_modeset_primary_pipes(crtc_state), \ + _intel_modeset_secondary_pipes(crtc_state), \ + i) total: 0 errors, 1 warnings, 6 checks, 234 lines checked
