September 9, 2024 at 2:30 PM, "Thomas Zimmermann" <tzimmermann@xxxxxxx mailto:tzimmermann@xxxxxxx?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote: > > Call drm_client_setup_with_color_mode() to run the kernel's default > client setup for DRM. Set fbdev_probe in struct drm_driver, so that > the client setup can start the common fbdev client. > > v3: > - add DRM_FBDEV_DMA_DRIVER_OPS macro > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Jyri Sarha <jyri.sarha@xxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > tilcdc patch looks identical to the previous version, but here is my ack again: Acked-by: Jyri Sarha <jyri.sarha@xxxxxx> Best regards, Jyri > > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index cd5eefa06060..8c9f3705aa6c 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -14,6 +14,7 @@ > #include <linux/pm_runtime.h> > > #include <drm/drm_atomic_helper.h> > +#include <drm/drm_client_setup.h> > #include <drm/drm_debugfs.h> > #include <drm/drm_drv.h> > #include <drm/drm_fbdev_dma.h> > @@ -374,7 +375,8 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev) > goto init_failed; > priv->is_registered = true; > > - drm_fbdev_dma_setup(ddev, bpp); > + drm_client_setup_with_color_mode(ddev, bpp); > + > return 0; > > init_failed: > @@ -472,6 +474,7 @@ DEFINE_DRM_GEM_DMA_FOPS(fops); > static const struct drm_driver tilcdc_driver = { > .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > DRM_GEM_DMA_DRIVER_OPS, > + DRM_FBDEV_DMA_DRIVER_OPS, > #ifdef CONFIG_DEBUG_FS > .debugfs_init = tilcdc_debugfs_init, > #endif > -- > 2.46.0 >
