RE: [PATCH 1/3] drm/i915/dp: use fsleep instead of usleep_rage for LT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jani,

AUX_RD interval can have maximum value of 256ms. usleep_range() is recommended to be used for 10uS-20ms range as per Documentation/timers/timers-howto.rst

 

 

So, switched to fsleep() which takes care of calling respective functions according to the delay.

 

Regards

Srikanth

 

-----Original Message-----
From: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>
Sent: Thursday, September 12, 2024 3:34 PM
To: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; intel-xe@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx
Cc: Srikanth V, NagaVenkata <nagavenkata.srikanth.v@xxxxxxxxx>
Subject: RE: [PATCH 1/3] drm/i915/dp: use fsleep instead of usleep_rage for LT

 

> -----Original Message-----

> From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>

> Sent: Thursday, September 12, 2024 2:32 PM

> To: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>;

> intel-xe@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx

> Cc: Murthy, Arun R <arun.r.murthy@xxxxxxxxx>; Srikanth V, NagaVenkata

> <nagavenkata.srikanth.v@xxxxxxxxx>

> Subject: Re: [PATCH 1/3] drm/i915/dp: use fsleep instead of

> usleep_rage for LT

>

> On Thu, 12 Sep 2024, Arun R Murthy <arun.r.murthy@xxxxxxxxx> wrote:

> > Aux RD Interval value depends on the value read from the dpcd

> > register which is updated from the sink device use flseep thereby we

> > adhere to the Documentation/timers/timers-howto.rst

>

> Please explain why instead of just referencing a file.

 

Sleeping for < 10us use udelay, for 10us to 20ms use usleep_range and for > 10ms use msleep.

fsleep() will call the particular api based on the above condition.

 

Thanks and Regards,

Arun R Murthy

--------------------


[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux