Re: [PATCH 4/8] drm/bridge: ti-sn65dsi86: annotate ti_sn_pwm_pin_{request, release} with __maybe_unused

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Sep 11, 2024 at 1:02 AM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
>
> On Tue, 10 Sep 2024, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> > Hi,
> >
> > On Tue, Sep 10, 2024 at 3:04 AM Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> >>
> >> Building with clang, W=1, CONFIG_PM=n and CONFIG_OF_GPIO=n leads to
> >> warning about unused ti_sn_pwm_pin_request() and
> >> ti_sn_pwm_pin_release(). Fix by annotating them with __maybe_unused.
> >>
> >> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> >> inline functions for W=1 build").
> >>
> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> >>
> >> ---
> >>
> >> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> >> Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
> >> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> >> Cc: Robert Foss <rfoss@xxxxxxxxxx>
> >> Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>
> >> Cc: Jonas Karlman <jonas@xxxxxxxxx>
> >> Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> >> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> >> ---
> >>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> >
> > I'm happy to land this in drm-misc-next unless there are any extra
> > dependencies. Let me know. In some sense I guess this could even be
> > considered a "Fix", though I guess given the history of the compiler
> > options that might be a bit of a stretch.
>
> drm-misc-next is fine. Agree on not considering this a fix.

It's only been on the list a day but it's simple so I just landed it
to drm-misc-next:

[4/8] drm/bridge: ti-sn65dsi86: annotate ti_sn_pwm_pin_{request,
release} with __maybe_unused
      commit: 868cd000c19f77e4c25ce87c47b6f951facf4394




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux