On Tue, Sep 03, 2024 at 10:32:03AM GMT, Jani Nikula wrote:
On Mon, 02 Sep 2024, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote:
On Mon, Sep 02, 2024 at 08:13:59PM GMT, Jani Nikula wrote:
There's considerable overlap in i915 and xe PCI ID macros, and (as can
be seen in this series) they get updated out of sync. With i915 display
continuing to use PCI IDs for platforms that i915 core does not support,
humn.. but display is not using a separate device. It's rather the same
that we bind to the xe driver. Why does i915 need to know the PCI ID?
Because display does its own device identification for display, for
display needs, without depending on either xe or i915 passing along some
data that has to be managed between all three.
I'd rather have the drivers pass to display what it needs rather than
having logic in 3 places for similar things.
but xe does, the duplication will just increase. Just use a single file
for all of them.
I'd expect PCI IDs to stop being added in one header and start to be
added in another.
Display could include xe_pciids.h too, and start using the XE_*_IDS()
macros for LNL+, but still the intersection of PCI IDs from both i915
and xe should match.
I will disagree and commit here, because leaving it in the current state
is even worse.
Acked-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
Lucas De Marchi
BR,
Jani.
--
Jani Nikula, Intel
