On Mon, 09 Sep 2024, Imre Deak <imre.deak@xxxxxxxxx> wrote: > Dump the descriptor of the detected LTTPRs in non-transparent mode to > help the debugging related to LTTPRs easier. > > v2: Use drm_dp_dump_lttpr_desc() instead of the driver specific > equivalent. > v3: Add empty line between license and header section. (Ankit) > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> # v1 > Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx> > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > > Resending [1] now, after the corresponding DRM core helper is merged to > drm-intel-next. > > [1] https://lore.kernel.org/all/20240708190029.271247-7-imre.deak@xxxxxxxxx > > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index f45797c1a2051..b7bd8135c1138 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -21,6 +21,8 @@ > * IN THE SOFTWARE. > */ > > +#include <drm/display/drm_dp_helper.h> > + > #include <linux/debugfs.h> > > #include <drm/display/drm_dp_helper.h> It's already here now. BR, Jani. > @@ -210,8 +212,10 @@ static int intel_dp_init_lttpr(struct intel_dp *intel_dp, const u8 dpcd[DP_RECEI > > lttpr_count = intel_dp_init_lttpr_phys(intel_dp, dpcd); > > - for (i = 0; i < lttpr_count; i++) > + for (i = 0; i < lttpr_count; i++) { > intel_dp_read_lttpr_phy_caps(intel_dp, dpcd, DP_PHY_LTTPR(i)); > + drm_dp_dump_lttpr_desc(&intel_dp->aux, DP_PHY_LTTPR(i)); > + } > > return lttpr_count; > } -- Jani Nikula, Intel
