It's bugged me for a long time that we poke the intel_pps->pps members directly in a number of places, especially around VLV/CHV PPS pipe handling. Hide it all inside intel_pps.c. The function naming may be a bit contrived, but IMO better than the status quo. BR, Jani. Jani Nikula (4): drm/i915/pps: add intel_pps_dp_init() for all DP init drm/i915/pps: move active_pipe set to intel_pps_dp_encoder_reset() drm/i915/pps: add intel_pps_dp_power_down() drm/i915/pps: add intel_pps_backlight_initial_pipe() drivers/gpu/drm/i915/display/g4x_dp.c | 19 +------ drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 23 ++------- drivers/gpu/drm/i915/display/intel_pps.c | 63 +++++++++++++++++++++++- drivers/gpu/drm/i915/display/intel_pps.h | 6 ++- 5 files changed, 73 insertions(+), 40 deletions(-) -- 2.39.2
