== Series Details == Series: drm/i915 & drm/xe: shared PCI ID macros URL : https://patchwork.freedesktop.org/series/138110/ State : warning == Summary == Error: dim checkpatch failed 4c49328848e5 drm/i915/pciids: use designated initializers in INTEL_VGA_DEVICE() ecd7fe3734dc drm/i915/pciids: separate ARL and MTL PCI IDs b8a2ec141598 drm/xe/pciids: add some missing ADL-N PCI IDs 3c67ba95d657 drm/xe/pciids: separate RPL-U and RPL-P PCI IDs dd8ac12f2756 drm/xe/pciids: separate ARL and MTL PCI IDs -:34: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #34: FILE: include/drm/intel/xe_pciids.h:180: +#define XE_ARL_IDS(MACRO__, ...) \ + MACRO__(0x7D41, ## __VA_ARGS__), \ + MACRO__(0x7D51, ## __VA_ARGS__), \ + MACRO__(0x7D67, ## __VA_ARGS__), \ + MACRO__(0x7DD1, ## __VA_ARGS__) -:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects? #34: FILE: include/drm/intel/xe_pciids.h:180: +#define XE_ARL_IDS(MACRO__, ...) \ + MACRO__(0x7D41, ## __VA_ARGS__), \ + MACRO__(0x7D51, ## __VA_ARGS__), \ + MACRO__(0x7D67, ## __VA_ARGS__), \ + MACRO__(0x7DD1, ## __VA_ARGS__) total: 1 errors, 0 warnings, 1 checks, 31 lines checked bdcf19eb1d20 drm/i915/pciids: add PVC PCI ID macros -:22: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #22: FILE: include/drm/intel/i915_pciids.h:783: +#define INTEL_PVC_IDS(MACRO__, ...) \ + MACRO__(0x0B69, ## __VA_ARGS__), \ + MACRO__(0x0B6E, ## __VA_ARGS__), \ + MACRO__(0x0BD4, ## __VA_ARGS__), \ + MACRO__(0x0BD5, ## __VA_ARGS__), \ + MACRO__(0x0BD6, ## __VA_ARGS__), \ + MACRO__(0x0BD7, ## __VA_ARGS__), \ + MACRO__(0x0BD8, ## __VA_ARGS__), \ + MACRO__(0x0BD9, ## __VA_ARGS__), \ + MACRO__(0x0BDA, ## __VA_ARGS__), \ + MACRO__(0x0BDB, ## __VA_ARGS__), \ + MACRO__(0x0BE0, ## __VA_ARGS__), \ + MACRO__(0x0BE1, ## __VA_ARGS__), \ + MACRO__(0x0BE5, ## __VA_ARGS__) -:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'MACRO__' - possible side-effects? #22: FILE: include/drm/intel/i915_pciids.h:783: +#define INTEL_PVC_IDS(MACRO__, ...) \ + MACRO__(0x0B69, ## __VA_ARGS__), \ + MACRO__(0x0B6E, ## __VA_ARGS__), \ + MACRO__(0x0BD4, ## __VA_ARGS__), \ + MACRO__(0x0BD5, ## __VA_ARGS__), \ + MACRO__(0x0BD6, ## __VA_ARGS__), \ + MACRO__(0x0BD7, ## __VA_ARGS__), \ + MACRO__(0x0BD8, ## __VA_ARGS__), \ + MACRO__(0x0BD9, ## __VA_ARGS__), \ + MACRO__(0x0BDA, ## __VA_ARGS__), \ + MACRO__(0x0BDB, ## __VA_ARGS__), \ + MACRO__(0x0BE0, ## __VA_ARGS__), \ + MACRO__(0x0BE1, ## __VA_ARGS__), \ + MACRO__(0x0BE5, ## __VA_ARGS__) total: 1 errors, 0 warnings, 1 checks, 22 lines checked 678e3b189426 drm/intel/pciids: rename i915_pciids.h to just pciids.h -:65: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #65: rename from include/drm/intel/i915_pciids.h total: 0 errors, 1 warnings, 0 checks, 47 lines checked 09326813e26b drm/xe: switch to common PCI ID macros -:113: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #113: deleted file mode 100644 total: 0 errors, 1 warnings, 0 checks, 91 lines checked