Re: [PATCH v9 2/3] drm/i915/lobf: No need to pass connector-state on lobf-compute-config.

["Nautiyal, Ankit K" <ankit.k.nautiyal@xxxxxxxxx>]

On 7/8/2024 8:52 PM, Animesh Manna wrote:
> Coonector state is not used in lobf compute config, so removed it.

nitpick: s/coonector/connector and  s/removed/remove

Add fixes tag.

With above fixed:

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@xxxxxxxxx>

> Signed-off-by: Animesh Manna <animesh.manna@xxxxxxxxx>
> ---
>   drivers/gpu/drm/i915/display/intel_alpm.c | 3 +--
>   drivers/gpu/drm/i915/display/intel_alpm.h | 3 +--
>   drivers/gpu/drm/i915/display/intel_dp.c   | 2 +-
>   3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 866b3b409c4d..021e970d8209 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -266,8 +266,7 @@ bool intel_alpm_compute_params(struct intel_dp *intel_dp,
>   }
>   
>   void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
> -				    struct intel_crtc_state *crtc_state,
> -				    struct drm_connector_state *conn_state)
> +				    struct intel_crtc_state *crtc_state)
>   {
>   	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
>   	struct drm_display_mode *adjusted_mode = &crtc_state->hw.adjusted_mode;
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.h b/drivers/gpu/drm/i915/display/intel_alpm.h
> index 8c409b10dce6..a17dfaa5248d 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.h
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.h
> @@ -17,8 +17,7 @@ void intel_alpm_init_dpcd(struct intel_dp *intel_dp);
>   bool intel_alpm_compute_params(struct intel_dp *intel_dp,
>   			       const struct intel_crtc_state *crtc_state);
>   void intel_alpm_lobf_compute_config(struct intel_dp *intel_dp,
> -				    struct intel_crtc_state *crtc_state,
> -				    struct drm_connector_state *conn_state);
> +				    struct intel_crtc_state *crtc_state);
>   void intel_alpm_configure(struct intel_dp *intel_dp,
>   			  const struct intel_crtc_state *crtc_state);
>   void intel_alpm_lobf_debugfs_add(struct intel_connector *connector);
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 3903f6ead6e6..8feec90538ae 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3009,7 +3009,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>   	intel_vrr_compute_config(pipe_config, conn_state);
>   	intel_dp_compute_as_sdp(intel_dp, pipe_config);
>   	intel_psr_compute_config(intel_dp, pipe_config, conn_state);
> -	intel_alpm_lobf_compute_config(intel_dp, pipe_config, conn_state);
> +	intel_alpm_lobf_compute_config(intel_dp, pipe_config);
>   	intel_dp_drrs_compute_config(connector, pipe_config, link_bpp_x16);
>   	intel_dp_compute_vsc_sdp(intel_dp, pipe_config, conn_state);
>   	intel_dp_compute_hdr_metadata_infoframe_sdp(intel_dp, pipe_config, conn_state);