Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-xe/drm-xe-next next-20240827] [cannot apply to drm-intel/for-linux-next-fixes linus/master v6.11-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-i915-wm-move-struct-intel_watermark_params-to-i9xx_wm-c/20240827-003437 base: git://anongit.freedesktop.org/drm-intel for-linux-next patch link: https://lore.kernel.org/r/a9aeb27f0107bdf3d2bd834a48583bc64072447a.1724689818.git.jani.nikula%40intel.com patch subject: [PATCH 5/7] drm/i915/display: include media/cec-notifier.h and linux/debugfs.h where needed config: i386-buildonly-randconfig-001-20240827 (https://download.01.org/0day-ci/archive/20240828/202408280033.x0jpUM2m-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240828/202408280033.x0jpUM2m-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408280033.x0jpUM2m-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): >> drivers/gpu/drm/i915/display/hsw_ips.c:320:58: error: expected ')' before string constant 320 | hsw_ips_debugfs_false_color_set, | ^ | ) 321 | "%llu\n"); | ~~~~~~~~ drivers/gpu/drm/i915/display/hsw_ips.c: In function 'hsw_ips_crtc_debugfs_add': >> drivers/gpu/drm/i915/display/hsw_ips.c:355:9: error: implicit declaration of function 'debugfs_create_file'; did you mean 'bus_create_file'? [-Werror=implicit-function-declaration] 355 | debugfs_create_file("i915_ips_false_color", 0644, crtc->base.debugfs_entry, | ^~~~~~~~~~~~~~~~~~~ | bus_create_file >> drivers/gpu/drm/i915/display/hsw_ips.c:356:36: error: 'hsw_ips_debugfs_false_color_fops' undeclared (first use in this function); did you mean 'hsw_ips_debugfs_false_color_set'? 356 | crtc, &hsw_ips_debugfs_false_color_fops); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | hsw_ips_debugfs_false_color_set drivers/gpu/drm/i915/display/hsw_ips.c:356:36: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/i915/display/hsw_ips.c: At top level: >> drivers/gpu/drm/i915/display/hsw_ips.c:288:12: warning: 'hsw_ips_debugfs_false_color_set' defined but not used [-Wunused-function] 288 | static int hsw_ips_debugfs_false_color_set(void *data, u64 val) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/gpu/drm/i915/display/hsw_ips.c:278:12: warning: 'hsw_ips_debugfs_false_color_get' defined but not used [-Wunused-function] 278 | static int hsw_ips_debugfs_false_color_get(void *data, u64 *val) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +320 drivers/gpu/drm/i915/display/hsw_ips.c bc37c98a3d44f7 Jani Nikula 2023-03-02 277 42b4c479025d92 Ville Syrjälä 2023-03-27 @278 static int hsw_ips_debugfs_false_color_get(void *data, u64 *val) 42b4c479025d92 Ville Syrjälä 2023-03-27 279 { 42b4c479025d92 Ville Syrjälä 2023-03-27 280 struct intel_crtc *crtc = data; 42b4c479025d92 Ville Syrjälä 2023-03-27 281 struct drm_i915_private *i915 = to_i915(crtc->base.dev); 42b4c479025d92 Ville Syrjälä 2023-03-27 282 42b4c479025d92 Ville Syrjälä 2023-03-27 283 *val = i915->display.ips.false_color; 42b4c479025d92 Ville Syrjälä 2023-03-27 284 42b4c479025d92 Ville Syrjälä 2023-03-27 285 return 0; 42b4c479025d92 Ville Syrjälä 2023-03-27 286 } 42b4c479025d92 Ville Syrjälä 2023-03-27 287 42b4c479025d92 Ville Syrjälä 2023-03-27 @288 static int hsw_ips_debugfs_false_color_set(void *data, u64 val) 42b4c479025d92 Ville Syrjälä 2023-03-27 289 { 42b4c479025d92 Ville Syrjälä 2023-03-27 290 struct intel_crtc *crtc = data; 42b4c479025d92 Ville Syrjälä 2023-03-27 291 struct drm_i915_private *i915 = to_i915(crtc->base.dev); 42b4c479025d92 Ville Syrjälä 2023-03-27 292 struct intel_crtc_state *crtc_state; 42b4c479025d92 Ville Syrjälä 2023-03-27 293 int ret; 42b4c479025d92 Ville Syrjälä 2023-03-27 294 42b4c479025d92 Ville Syrjälä 2023-03-27 295 ret = drm_modeset_lock(&crtc->base.mutex, NULL); 42b4c479025d92 Ville Syrjälä 2023-03-27 296 if (ret) 42b4c479025d92 Ville Syrjälä 2023-03-27 297 return ret; 42b4c479025d92 Ville Syrjälä 2023-03-27 298 42b4c479025d92 Ville Syrjälä 2023-03-27 299 i915->display.ips.false_color = val; 42b4c479025d92 Ville Syrjälä 2023-03-27 300 42b4c479025d92 Ville Syrjälä 2023-03-27 301 crtc_state = to_intel_crtc_state(crtc->base.state); 42b4c479025d92 Ville Syrjälä 2023-03-27 302 42b4c479025d92 Ville Syrjälä 2023-03-27 303 if (!crtc_state->hw.active) 42b4c479025d92 Ville Syrjälä 2023-03-27 304 goto unlock; 42b4c479025d92 Ville Syrjälä 2023-03-27 305 42b4c479025d92 Ville Syrjälä 2023-03-27 306 if (crtc_state->uapi.commit && 42b4c479025d92 Ville Syrjälä 2023-03-27 307 !try_wait_for_completion(&crtc_state->uapi.commit->hw_done)) 42b4c479025d92 Ville Syrjälä 2023-03-27 308 goto unlock; 42b4c479025d92 Ville Syrjälä 2023-03-27 309 42b4c479025d92 Ville Syrjälä 2023-03-27 310 hsw_ips_enable(crtc_state); 42b4c479025d92 Ville Syrjälä 2023-03-27 311 42b4c479025d92 Ville Syrjälä 2023-03-27 312 unlock: 42b4c479025d92 Ville Syrjälä 2023-03-27 313 drm_modeset_unlock(&crtc->base.mutex); 42b4c479025d92 Ville Syrjälä 2023-03-27 314 42b4c479025d92 Ville Syrjälä 2023-03-27 315 return ret; 42b4c479025d92 Ville Syrjälä 2023-03-27 316 } 42b4c479025d92 Ville Syrjälä 2023-03-27 317 42b4c479025d92 Ville Syrjälä 2023-03-27 318 DEFINE_DEBUGFS_ATTRIBUTE(hsw_ips_debugfs_false_color_fops, 42b4c479025d92 Ville Syrjälä 2023-03-27 319 hsw_ips_debugfs_false_color_get, 42b4c479025d92 Ville Syrjälä 2023-03-27 @320 hsw_ips_debugfs_false_color_set, 42b4c479025d92 Ville Syrjälä 2023-03-27 321 "%llu\n"); 42b4c479025d92 Ville Syrjälä 2023-03-27 322 bc37c98a3d44f7 Jani Nikula 2023-03-02 323 static int hsw_ips_debugfs_status_show(struct seq_file *m, void *unused) bc37c98a3d44f7 Jani Nikula 2023-03-02 324 { 1fb4da5f7858d7 Ville Syrjälä 2023-03-27 325 struct intel_crtc *crtc = m->private; 1fb4da5f7858d7 Ville Syrjälä 2023-03-27 326 struct drm_i915_private *i915 = to_i915(crtc->base.dev); bc37c98a3d44f7 Jani Nikula 2023-03-02 327 intel_wakeref_t wakeref; bc37c98a3d44f7 Jani Nikula 2023-03-02 328 bc37c98a3d44f7 Jani Nikula 2023-03-02 329 wakeref = intel_runtime_pm_get(&i915->runtime_pm); bc37c98a3d44f7 Jani Nikula 2023-03-02 330 bc37c98a3d44f7 Jani Nikula 2023-03-02 331 seq_printf(m, "Enabled by kernel parameter: %s\n", c39fc2aca32a93 Jouni Högander 2023-10-24 332 str_yes_no(i915->display.params.enable_ips)); bc37c98a3d44f7 Jani Nikula 2023-03-02 333 bc37c98a3d44f7 Jani Nikula 2023-03-02 334 if (DISPLAY_VER(i915) >= 8) { bc37c98a3d44f7 Jani Nikula 2023-03-02 335 seq_puts(m, "Currently: unknown\n"); bc37c98a3d44f7 Jani Nikula 2023-03-02 336 } else { bc37c98a3d44f7 Jani Nikula 2023-03-02 337 if (intel_de_read(i915, IPS_CTL) & IPS_ENABLE) bc37c98a3d44f7 Jani Nikula 2023-03-02 338 seq_puts(m, "Currently: enabled\n"); bc37c98a3d44f7 Jani Nikula 2023-03-02 339 else bc37c98a3d44f7 Jani Nikula 2023-03-02 340 seq_puts(m, "Currently: disabled\n"); bc37c98a3d44f7 Jani Nikula 2023-03-02 341 } bc37c98a3d44f7 Jani Nikula 2023-03-02 342 bc37c98a3d44f7 Jani Nikula 2023-03-02 343 intel_runtime_pm_put(&i915->runtime_pm, wakeref); bc37c98a3d44f7 Jani Nikula 2023-03-02 344 bc37c98a3d44f7 Jani Nikula 2023-03-02 345 return 0; bc37c98a3d44f7 Jani Nikula 2023-03-02 346 } bc37c98a3d44f7 Jani Nikula 2023-03-02 347 bc37c98a3d44f7 Jani Nikula 2023-03-02 348 DEFINE_SHOW_ATTRIBUTE(hsw_ips_debugfs_status); bc37c98a3d44f7 Jani Nikula 2023-03-02 349 1fb4da5f7858d7 Ville Syrjälä 2023-03-27 350 void hsw_ips_crtc_debugfs_add(struct intel_crtc *crtc) bc37c98a3d44f7 Jani Nikula 2023-03-02 351 { 1fb4da5f7858d7 Ville Syrjälä 2023-03-27 352 if (!hsw_crtc_supports_ips(crtc)) 1fb4da5f7858d7 Ville Syrjälä 2023-03-27 353 return; bc37c98a3d44f7 Jani Nikula 2023-03-02 354 42b4c479025d92 Ville Syrjälä 2023-03-27 @355 debugfs_create_file("i915_ips_false_color", 0644, crtc->base.debugfs_entry, 42b4c479025d92 Ville Syrjälä 2023-03-27 @356 crtc, &hsw_ips_debugfs_false_color_fops); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
