== Series Details == Series: CCS static load balance (rev2) URL : https://patchwork.freedesktop.org/series/137715/ State : warning == Summary == Error: dim checkpatch failed 6ad023c9bef4 drm/i915/gt: Avoid using masked workaround for CCS_MODE setting bde55a5f33ad drm/i915/gt: Move the CCS mode variable to a global position 03f682af8c44 drm/i915/gt: Allow the creation of multi-mode CCS masks 19e5972d44a5 drm/i915/gt: Refactor uabi engine class/instance list creation -:54: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #54: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:233: + GEM_BUG_ON(uabi_class >= ARRAY_SIZE(class_instance)); -:70: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #70: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:247: + GEM_BUG_ON(uabi_class >= total: 0 errors, 2 warnings, 0 checks, 56 lines checked ef12b46a4464 drm/i915/gem: Mark and verify UABI engine validity 597c6eb04140 drm/i915/gt: Introduce for_each_enabled_engine() and apply it in selftests -:30: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #30: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:196: +#define for_each_enabled_engine(engine__, gt__, id__) \ + for ((id__) = 0; \ + (id__) < I915_NUM_ENGINES; \ + (id__)++) \ + for_each_if (((engine__) = (gt__)->engine[(id__)]) && \ + (!RB_EMPTY_NODE(&(engine__)->uabi_node))) -:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects? #30: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:196: +#define for_each_enabled_engine(engine__, gt__, id__) \ + for ((id__) = 0; \ + (id__) < I915_NUM_ENGINES; \ + (id__)++) \ + for_each_if (((engine__) = (gt__)->engine[(id__)]) && \ + (!RB_EMPTY_NODE(&(engine__)->uabi_node))) -:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects? #30: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:196: +#define for_each_enabled_engine(engine__, gt__, id__) \ + for ((id__) = 0; \ + (id__) < I915_NUM_ENGINES; \ + (id__)++) \ + for_each_if (((engine__) = (gt__)->engine[(id__)]) && \ + (!RB_EMPTY_NODE(&(engine__)->uabi_node))) -:34: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #34: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:200: + for_each_if (((engine__) = (gt__)->engine[(id__)]) && \ total: 1 errors, 1 warnings, 2 checks, 738 lines checked efaae0b34442 drm/i915/gt: Manage CCS engine creation within UABI exposure 85128e042d62 drm/i915/gt: Remove cslices mask value from the CCS structure c7ed84b770b7 drm/i915/gt: Expose the number of total CCS slices 1e2eea42edca drm/i915/gt: Store engine-related sysfs kobjects 56fa96057385 drm/i915/gt: Store active CCS mask -:70: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #70: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:120: + GEM_BUG_ON(ccs_mode); total: 0 errors, 1 warnings, 0 checks, 83 lines checked d3e1b64e7fe2 drm/i915: Protect access to the UABI engines list with a mutex 6f7d4157f4f5 drm/i915/gt: Isolate single sysfs engine file creation 004ebf5460c0 drm/i915/gt: Implement creation and removal routines for CCS engines -:119: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #119: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:206: + GEM_BUG_ON(rb_find_add(&e->uabi_node, -:123: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants #123: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:210: + GEM_BUG_ON(intel_engine_lookup_user(i915, e->uabi_class, total: 0 errors, 2 warnings, 0 checks, 146 lines checked f3f4f5e5fc08 drm/i915/gt: Allow the user to change the CCS mode through sysfs
