Re: [PATCH v2 47/86] drm/vc4: Run DRM default client setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 21 Aug 2024 at 14:04, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>
> Call drm_client_setup_with_fourcc() to run the kernel's default client
> setup for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> v2:
> - use drm_client_setup_with_fourcc()
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> Cc: Raspberry Pi Kernel Maintenance <kernel-list@xxxxxxxxxxxxxxx>

Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/vc4/vc4_drv.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index c133e96b8aca..86786caaf8a5 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -32,8 +32,10 @@
>
>  #include <drm/drm_aperture.h>
>  #include <drm/drm_atomic_helper.h>
> +#include <drm/drm_client_setup.h>
>  #include <drm/drm_drv.h>
>  #include <drm/drm_fbdev_dma.h>
> +#include <drm/drm_fourcc.h>
>  #include <drm/drm_vblank.h>
>
>  #include <soc/bcm2835/raspberrypi-firmware.h>
> @@ -212,6 +214,7 @@ const struct drm_driver vc4_drm_driver = {
>         .gem_create_object = vc4_create_object,
>
>         DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc4_bo_dumb_create),
> +       DRM_FBDEV_DMA_DRIVER_OPS,
>
>         .ioctls = vc4_drm_ioctls,
>         .num_ioctls = ARRAY_SIZE(vc4_drm_ioctls),
> @@ -389,7 +392,7 @@ static int vc4_drm_bind(struct device *dev)
>         if (ret < 0)
>                 goto err;
>
> -       drm_fbdev_dma_setup(drm, 16);
> +       drm_client_setup_with_fourcc(drm, DRM_FORMAT_RGB565);
>
>         return 0;
>
> --
> 2.46.0
>



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux