Hi Raag, > + /* > + * Calculate fan speed in RPM by time averaging two subsequent > + * readings in minutes. > + * RPM = number of rotations * msecs per minute / time in msecs > + */ > + *val = DIV_ROUND_UP(rotations * (MSEC_PER_SEC * 60), time); once you find the correct operator here, please feel free to add: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> Normally these get me confused, I'm happy Andy is looking after it :-) Thanks, Andi