On Mon, 2024-08-19 at 13:23 +0000, Kahola, Mika wrote: > > -----Original Message----- > > From: Hogander, Jouni <jouni.hogander@xxxxxxxxx> > > Sent: Monday, August 19, 2024 12:26 PM > > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > Cc: Manna, Animesh <animesh.manna@xxxxxxxxx>; Kahola, Mika > > <mika.kahola@xxxxxxxxx>; Hogander, Jouni <jouni.hogander@xxxxxxxxx> > > Subject: [PATCH] drm/i915/psr: Prevent Panel Replay if CRC > > calculation is enabled > > > > Similarly as for PSR2 CRC calculation seems to timeout when Panel > > Replay is enabled. > > Fix this by falling back to PSR if CRC calculation is enabled. > > > > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2266 > > Reviewed-by: Mika Kahola <mika.kahola@xxxxxxxxx> Thank you Mika for the review. This is now pushed to drm-intel-next. BR, Jouni Högander > > > Signed-off-by: Jouni Högander <jouni.hogander@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > > b/drivers/gpu/drm/i915/display/intel_psr.c > > index 9cb1cdaaeefa7..572dcdf77453c 100644 > > --- a/drivers/gpu/drm/i915/display/intel_psr.c > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > > @@ -1586,6 +1586,12 @@ _panel_replay_compute_config(struct intel_dp > > *intel_dp, > > if (!alpm_config_valid(intel_dp, crtc_state, true)) > > return false; > > > > + if (crtc_state->crc_enabled) { > > + drm_dbg_kms(&i915->drm, > > + "Panel Replay not enabled because it > > would inhibit pipe > > CRC calculation\n"); > > + return false; > > + } > > + > > return true; > > } > > > > -- > > 2.34.1 >
