On Tue, 20 Aug 2024, Yu Jiaoliang <yujiaoliang@xxxxxxxx> wrote:
> Let the kememdup_array() take care about multiplication and possible
> overflows.
> Signed-off-by: Yu Jiaoliang <yujiaoliang@xxxxxxxx>
For future reference, please look at git log for the file instead of
inventing subject prefixes.
There should be a blank line between commit message and trailers.
Other than that,
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 09a287c1aedd..d90348c56765 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -111,8 +111,8 @@ static void wa_init_finish(struct i915_wa_list *wal)
> {
> /* Trim unused entries. */
> if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) {
> - struct i915_wa *list = kmemdup(wal->list,
> - wal->count * sizeof(*list),
> + struct i915_wa *list = kmemdup_array(wal->list,
> + wal->count, sizeof(*list),
> GFP_KERNEL);
>
> if (list) {
--
Jani Nikula, Intel
