On Thu, 15 Aug 2024, Imre Deak <imre.deak@xxxxxxxxx> wrote: > On Thu, Aug 15, 2024 at 03:00:02PM +0300, Jani Nikula wrote: >> The function isn't used outside of intel_display_power.c. Make it >> static. >> >> Suggested-by: Imre Deak <imre.deak@xxxxxxxxx> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx> Thanks, pushed to din. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_display_power.c | 2 +- >> drivers/gpu/drm/i915/display/intel_display_power.h | 3 --- >> 2 files changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c >> index cf8b38f2ebf5..39ab3117265c 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_power.c >> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c >> @@ -36,7 +36,7 @@ >> for_each_power_well_reverse(__dev_priv, __power_well) \ >> for_each_if(test_bit((__domain), (__power_well)->domains.bits)) >> >> -const char * >> +static const char * >> intel_display_power_domain_str(enum intel_display_power_domain domain) >> { >> switch (domain) { >> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h >> index 0962f6aaeee6..425452c5a469 100644 >> --- a/drivers/gpu/drm/i915/display/intel_display_power.h >> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h >> @@ -183,9 +183,6 @@ void intel_display_power_resume(struct drm_i915_private *i915); >> void intel_display_power_set_target_dc_state(struct drm_i915_private *dev_priv, >> u32 state); >> >> -const char * >> -intel_display_power_domain_str(enum intel_display_power_domain domain); >> - >> bool intel_display_power_is_enabled(struct drm_i915_private *dev_priv, >> enum intel_display_power_domain domain); >> intel_wakeref_t intel_display_power_get(struct drm_i915_private *dev_priv, >> -- >> 2.39.2 >> -- Jani Nikula, Intel